fix: improve SSH tunnel credential validation and error handling#1390
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix: improve SSH tunnel credential validation and error handling#1390sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where warehouse connections configured with SSH tunneling could fail with a
KeyErrorif required SSH credentials (specificallyssh_key) were missing from the stored configuration. Previously, this resulted in a genericHttpError: Failed to get schemas(500 Internal Server Error).Changes Made:
ddpui/utils/helpers.py-map_airbyte_keys_to_postgres_keys:method["ssh_key"],method["tunnel_host"], etc.) with safe.get()calls.tunnel_host,tunnel_port,tunnel_user, andssh_keyfor key-based authentication).ValueErroris now raised with a descriptive message.ddpui/core/warehousefunctions.py-get_warehouse_data:ValueError(raised by the helper function).ValueErroris caught, anHttpError(400)(Bad Request) is now returned to the user, providing a clear, actionable message about the misconfigured credentials, instead of a generic 500 error.This ensures that misconfigured SSH tunnel connections provide a user-friendly error message, improving the debugging experience and preventing unexpected server errors.
Fixes DALGO-BACKEND-2BE