Skip to content

fix: Reduce Sentry noise from dbt workspace not setup errors#1401

Draft
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/dbt-sentry-noise
Draft

fix: Reduce Sentry noise from dbt workspace not setup errors#1401
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/dbt-sentry-noise

Conversation

@sentry

@sentry sentry Bot commented Jun 3, 2026

Copy link
Copy Markdown

This PR addresses the issue where HttpError: dbt workspace not setup was being logged as an error in Sentry, causing unnecessary noise. This error occurs when an organization does not have a dbt workspace configured, which is an expected condition, not an actual error.

Changes made:

  • Added an early if not org.dbt: return "Not available" guard to both get_dbt_version() and get_edr_version() functions in ddpui/ddpdbt/elementary_service.py. This prevents DbtProjectManager.gather_dbt_project_params() from being called with a None org.dbt and thus avoids the HttpError entirely for unconfigured dbt workspaces.
  • Downgraded the log level from logger.error to logger.info in the exception handling blocks of both get_dbt_version() and get_edr_version(). This ensures that any other unexpected exceptions in these functions are logged at a less critical level, further reducing Sentry noise for non-critical issues.

Fixes DALGO-BACKEND-2HJ

@sentry

sentry Bot commented Jun 3, 2026

Copy link
Copy Markdown
Author

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.59%. Comparing base (3347e59) to head (a5b4870).

Files with missing lines Patch % Lines
ddpui/ddpdbt/elementary_service.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1401      +/-   ##
==========================================
- Coverage   59.59%   59.59%   -0.01%     
==========================================
  Files         138      138              
  Lines       16561    16565       +4     
==========================================
+ Hits         9870     9872       +2     
- Misses       6691     6693       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants