fix: handle NoneType from redis.get in SingleTaskProgress.get#1402
Open
sentry[bot] wants to merge 1 commit into
Open
fix: handle NoneType from redis.get in SingleTaskProgress.get#1402sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
TypeError: the JSON object must be str, bytes or bytearray, not NoneTypeoccurring inddpui.celeryworkers.tasks.get_connection_catalog_task.The root cause was identified in
ddpui/utils/singletaskprogress.py, specifically in theSingleTaskProgress.get()method. When a Redis key associated with a task's progress expires,self.redis.get(self.task_key_)returnsNone. The subsequent call tojson.loads(None)then raises theTypeError.The fix involves adding a
Nonecheck before callingjson.loads. Ifredis.get()returnsNone, theget()method now returns an empty list[]. This behavior is consistent with the initial state set in__init__and aligns with the handling already present in the staticfetch()method.This change ensures that progress tracking can gracefully handle expired Redis keys without crashing, allowing
add()andget()operations to proceed by effectively resetting the progress for an expired task.Fixes DALGO-BACKEND-FV