refactor: centralize shared parameter definitions in params.py#32
Merged
Conversation
Extracts 8 duplicated parameter types (DeploymentId, FlowRunId, ChartId, DashboardId, ConnectionId, SourceId, SchemaName, TableName) into params.py using Annotated[str, Field(description=...)]. Updates 6 tool files to use the shared types. Closes #6. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Preserved dev dependencies and ruff/pytest tool config from main alongside the unit test suite additions from this branch. https://claude.ai/code/session_011MeXGRNe15ksjbwsDM8ULN
Resolved conflicts in 6 tool files (charts, connections, dashboards, pipelines, sources, warehouse) by combining typed params from this branch with adapt_context() pattern from main. Fixed ruff E402 in server.py. https://claude.ai/code/session_011MeXGRNe15ksjbwsDM8ULN
Claude Code reads slash commands from .claude/commands/, not .claude/skills/. Renamed directory so /progress, /mcp-research, /ngo-onboarding work. https://claude.ai/code/session_011MeXGRNe15ksjbwsDM8ULN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/dalgo_mcp/params.pywith 10 sharedAnnotatedparameter typespipelines.py,warehouse.py,charts.py,dashboards.py,connections.py,sources.pyto use shared typesArgs:docstring entries for centralized paramsWhy
8 parameter names were duplicated across 5+ tools with identical descriptions. A single change to a parameter description (e.g. "The Prefect deployment ID" → "The Prefect pipeline deployment ID") now only needs to happen in one place.
Test plan
NameErrororImportErroron server startCloses #6
🤖 Generated with Claude Code