feat: return numAffectedRows in Kysely driver #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the great project!
I moved a part of my project from better-sqlite3/Kysely to SQLocal/Kysely since I find it more convenient to work with a WASM blob rather than having to build a binary. In the process I noticed that I was no longer getting the
numAffectedRowsfrom Kysely'sexecuteQuerycall. This PR implement that.To do this, I had to expose
execSqlmethod on the SQLocal/client class. Please let me know if this is not the way. It also adds alastAffectedRowsfield to the transaction field.Tests were added as well.
Cheers