Enhance Bob sync metadata and reminders integration #275

zulumonkeymetallic · 2025-09-30T22:20:26Z

Summary

wire up background Bob sync metadata handling and idempotent reminder integration
refresh Firebase sync orchestration, logging, and UI affordances
document rollout steps and capture outstanding follow-ups

Testing

not run (not applicable)

… Google config, add Auth window, implement FirebaseSyncService with idempotency, main-actor fixes for Reminders access, and logging. Update project to include new sources.

… keep canImport guards. Build verified.

…e and *.code-workspace

…issues.sh to open issues via gh when enabled.

Copilot

Pull Request Overview

This PR implements comprehensive Bob sync metadata handling and Firebase integration for the Reminders MenuBar app. It transforms the application from a standalone reminders manager into a bidirectional sync tool that connects Apple Reminders with Firebase/Firestore, enabling cloud-based collaboration and cross-platform task management.

Adds complete Firebase authentication and sync infrastructure with Google Sign-In support
Implements background sync scheduling and manual sync controls with comprehensive UI feedback
Introduces theme-to-calendar mapping system for automated reminder organization

Reviewed Changes

Copilot reviewed 37 out of 40 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
tools/swiftlint/LICENSE	Adds MIT license for SwiftLint tooling
scripts/create_issues.sh	Automated script for creating GitHub issues tracking sync enhancements
reminders-menubar/reminders_menubar.entitlements	Adds Firebase-required entitlements for network, reminders, and keychain access
reminders-menubar/Views/Windows/ThemeCalendarMappingView.swift	New UI for mapping Bob themes to Reminders calendars
reminders-menubar/Views/Windows/KeyboardShortcutView.swift	Updates keyboard shortcut configuration for Bob sync
reminders-menubar/Views/Windows/FirebaseAuthView.swift	Complete Firebase authentication interface with Google Sign-In
reminders-menubar/Views/SettingsBarView/SettingsBarSyncIndicator.swift	Sync status indicator with last sync timestamp
reminders-menubar/Views/SettingsBarView/SettingsBarGearMenu.swift	Adds Bob sync menu with background sync controls
reminders-menubar/Views/ContentView.swift	Integrates sync feedback toast notifications
reminders-menubar/Services/*	Core sync services including Firebase integration, logging, and background scheduling
reminders-menubar/Constants.swift	Updates bundle IDs and adds native Reminders integration toggle

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-30T22:22:52Z

scripts/create_issues.sh

+if ! command -v gh >/dev/null 2>&1; then
+  echo "Error: GitHub CLI (gh) is required. Install from https://cli.github.com/" >&2
+  exit 1
+fi


[nitpick] Consider adding a check for required environment variables or configuration before attempting to create issues. The script assumes GitHub CLI is authenticated and has proper repository access permissions.

Copilot · 2025-09-30T22:22:52Z

reminders-menubar/Views/Windows/ThemeCalendarMappingView.swift

+                    }
+                }
+                .labelsHidden()
+                Button("Add/Update") { addMapping() }.disabled((newTheme.trimmingCharacters(in: .whitespaces).isEmpty) || selectedListId == nil)


[nitpick] Extract the validation logic into a computed property or function for better readability and reusability. The inline condition is complex and repeated logic appears elsewhere.

Copilot · 2025-09-30T22:22:52Z

reminders-menubar/Views/Windows/ThemeCalendarMappingView.swift

+    private func loadAvailableThemes(force: Bool) async {
+#if canImport(FirebaseFirestore)
+        if !FirebaseManager.shared.isConfigured {
+            FirebaseManager.shared.configureIfNeeded()
+        }


[nitpick] The function is excessively long (100+ lines) and handles multiple responsibilities including network requests, error handling, caching, and UI updates. Consider breaking this into smaller, focused functions.

Copilot · 2025-09-30T22:22:53Z

reminders-menubar/Services/FirebaseSyncService.swift

+// swiftlint:disable cyclomatic_complexity function_body_length type_body_length file_length
+actor FirebaseSyncService {


[nitpick] The SwiftLint disable comment indicates this service has grown too large and complex. Consider breaking this into smaller, focused services (e.g., TaskSyncService, ReminderImportService, ConflictResolutionService) to improve maintainability and testability.

Copilot · 2025-09-30T22:22:53Z

reminders-menubar/Services/FirebaseSyncService.swift

+    // - Updates fields both directions (title, due, completion)
+    // - Clears mappings for tasks whose reminders are gone
+    // - Best-effort delete: if task has deleted flag, remove reminder
+    func syncNow(targetCalendar preferredCalendar: EKCalendar?) async -> (created: Int, updated: Int, errors: [String]) {


[nitpick] This function is extremely long (650+ lines) and handles numerous responsibilities including task fetching, conflict resolution, duplicate detection, and batch operations. This violates the single responsibility principle and makes testing and debugging difficult.

Copilot · 2025-09-30T22:22:53Z

reminders-menubar/Services/SyncLogService.swift

+    private func rotateIfNeeded(_ url: URL) {
+        // Simple size-based rotation at ~1 MiB
+        let limit: UInt64 = 1 * 1024 * 1024


[nitpick] The rotation logic doesn't handle potential race conditions when multiple sync operations run concurrently. Consider adding file locking or atomic operations to prevent corruption during log rotation.

Copilot · 2025-09-30T22:22:53Z

reminders-menubar/Services/BackgroundSyncService.swift

+        scheduler.schedule { completion in
+            Task {
+                // Preflight
+                if FirebaseManager.shared.db != nil, await RemindersService.shared.hasFullRemindersAccess() {
+                    _ = await FirebaseSyncService.shared.syncNow(targetCalendar: nil)
+                }
+                completion(.finished)
+            }
+        }


Background sync errors are silently ignored. Consider logging failures and potentially adjusting the retry schedule based on error types to improve reliability.

Copilot · 2025-09-30T22:22:53Z

reminders-menubar/Constants.swift

+    static let mainBundleId = "com.jc1.tech.bob"
+    static let launcherBundleId = "com.jc1.tech.bob.launcher"


[nitpick] The bundle ID change suggests this is a fork or rebrand, but the hardcoded values should be configurable through build settings or Info.plist to support different deployment environments.

Suggested change

static let mainBundleId = "com.jc1.tech.bob"

static let launcherBundleId = "com.jc1.tech.bob.launcher"

static var mainBundleId: String {

return Bundle.main.bundleIdentifier ?? "-"

}

static var launcherBundleId: String {

// Reads "LauncherBundleIdentifier" from Info.plist

return Bundle.main.infoDictionary?["LauncherBundleIdentifier"] as? String ?? "-"

}

Copilot · 2025-09-30T22:22:54Z

reminders-menubar.xcodeproj/project.pbxproj

 				GCC_WARN_UNUSED_VARIABLE = YES;
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
-				MACOSX_DEPLOYMENT_TARGET = 11.0;
+				MACOSX_DEPLOYMENT_TARGET = 15.0;


[nitpick] The deployment target was raised from 11.0 to 15.0, which significantly reduces device compatibility. This may be unnecessarily restrictive since many Firebase and sync features could work on earlier macOS versions.

Suggested change

MACOSX_DEPLOYMENT_TARGET = 15.0;

MACOSX_DEPLOYMENT_TARGET = 11.0;

zulumonkeymetallic added 5 commits September 24, 2025 21:21

iOS Reminders full sync: add Firebase (Auth, Firestore) via SPM, wire…

12ebfbc

… Google config, add Auth window, implement FirebaseSyncService with idempotency, main-actor fixes for Reminders access, and logging. Update project to include new sources.

Add Google Sign-In via SPM; adapt macOS API to present from NSWindow;…

cf6987e

… keep canImport guards. Build verified.

Chore: remove mistakenly committed bundle & workspace; ignore *.bundl…

e8ccc77

…e and *.code-workspace

Docs: add ENHANCEMENTS.md with proposals; Script: add scripts/create_…

4c9d88c

…issues.sh to open issues via gh when enabled.

Enhance Bob sync metadata and reminders integration

9dcf5a7

Copilot AI review requested due to automatic review settings September 30, 2025 22:20

Copilot AI reviewed Sep 30, 2025

View reviewed changes

docs: update ENHANCEMENTS with recent sync changes and notes

43ef552

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Enhance Bob sync metadata and reminders integration #275

Enhance Bob sync metadata and reminders integration #275

Uh oh!

zulumonkeymetallic commented Sep 30, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		// swiftlint:disable cyclomatic_complexity function_body_length type_body_length file_length
		actor FirebaseSyncService {

		static let mainBundleId = "com.jc1.tech.bob"
		static let launcherBundleId = "com.jc1.tech.bob.launcher"

-    static let mainBundleId = "com.jc1.tech.bob"
-    static let launcherBundleId = "com.jc1.tech.bob.launcher"
+    static var mainBundleId: String {
+        return Bundle.main.bundleIdentifier ?? "-"
+    }
+    static var launcherBundleId: String {
+        // Reads "LauncherBundleIdentifier" from Info.plist
+        return Bundle.main.infoDictionary?["LauncherBundleIdentifier"] as? String ?? "-"
+    }

	MACOSX_DEPLOYMENT_TARGET = 15.0;
	MACOSX_DEPLOYMENT_TARGET = 11.0;

Uh oh!

Enhance Bob sync metadata and reminders integration #275

Are you sure you want to change the base?

Enhance Bob sync metadata and reminders integration #275

Uh oh!

Conversation

zulumonkeymetallic commented Sep 30, 2025

Summary

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant