Validate all items in a collection rather than stopping at the first validation failure. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han stopping at the first failure. Also adds tests for dictionary collections.
Owner
|
Seems there are some existing tests that verify the current behavior that this change breaks. |
Author
|
So I see. I ran all the tests locally, I'll check the output and see what ones I missed and make sure they pass correctly. |
Author
|
Not correct yet. May need different approach and flags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the title says. Test cases are included to verify it's working correctly. Test cases for dictionary collections were added because they weren't there originally and I'm paranoid.
fix #68