-
Notifications
You must be signed in to change notification settings - Fork 2
fix: start service on boot and update gradle #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gvillo
wants to merge
2
commits into
Dan8Oren:main
Choose a base branch
from
gvillo:fix/start-service-on-boot-and-update-gradle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
129 changes: 87 additions & 42 deletions
129
app/src/main/java/io/github/miclock/receiver/BootCompletedReceiver.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,74 +1,119 @@ | ||
| // app/src/main/java/com/example/miclock/BootCompletedReceiver.kt | ||
| package io.github.miclock.receiver | ||
|
|
||
| import android.Manifest | ||
| import android.app.NotificationManager | ||
| import android.app.AlarmManager | ||
| import android.app.PendingIntent | ||
| import android.content.BroadcastReceiver | ||
| import android.content.Context | ||
| import android.content.Intent | ||
| import android.content.pm.PackageManager | ||
| import android.os.Build | ||
| import android.os.SystemClock | ||
| import android.util.Log | ||
| import androidx.core.content.ContextCompat | ||
| import androidx.work.OneTimeWorkRequestBuilder | ||
| import androidx.work.WorkManager | ||
| import io.github.miclock.worker.BootServiceWorker | ||
| import java.util.concurrent.TimeUnit | ||
| import io.github.miclock.service.MicLockService | ||
|
|
||
| /** | ||
| * Receives BOOT_COMPLETED broadcast and schedules a WorkManager task to start the service. | ||
| * This approach is required for Android 15+ to avoid ForegroundServiceStartNotAllowedException | ||
| * when starting foreground services directly from BOOT_COMPLETED. | ||
| * After boot / unlock / package replaced, schedules **MicLockService** via | ||
| * [PendingIntent.getForegroundService] + [AlarmManager]. Unlike [Context.startForegroundService] | ||
| * from app code or [android.app.Activity] launched from a worker, alarm delivery is a | ||
| * **system-sent PendingIntent** — not blocked by goo.gle/android-bal the way `BootResumeActivity` was. | ||
| * | ||
| * Delay lets CE storage and audio stack settle after reboot. | ||
| */ | ||
| class BootCompletedReceiver : BroadcastReceiver() { | ||
| override fun onReceive(context: Context, intent: Intent) { | ||
| if (intent.action == Intent.ACTION_BOOT_COMPLETED || intent.action == Intent.ACTION_MY_PACKAGE_REPLACED) { | ||
| Log.d(TAG, "Received ${intent.action}") | ||
| val action = intent.action ?: return | ||
| val shouldSchedule = | ||
| when (action) { | ||
| Intent.ACTION_BOOT_COMPLETED, | ||
| Intent.ACTION_USER_UNLOCKED, | ||
| Intent.ACTION_MY_PACKAGE_REPLACED -> true | ||
| else -> false | ||
| } | ||
| if (!shouldSchedule) { | ||
| Log.d(TAG, "Ignoring action: $action") | ||
| return | ||
| } | ||
|
|
||
| val micGranted = ContextCompat.checkSelfPermission( | ||
| context, | ||
| Manifest.permission.RECORD_AUDIO, | ||
| ) == PackageManager.PERMISSION_GRANTED | ||
| Log.d(TAG, "Received $action") | ||
|
|
||
| // Check notification status but don't require it | ||
| val nm = context.getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager | ||
| val notifsGranted = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) { // API 33+ | ||
| nm.areNotificationsEnabled() && ContextCompat.checkSelfPermission( | ||
| context, | ||
| Manifest.permission.POST_NOTIFICATIONS, | ||
| ) == PackageManager.PERMISSION_GRANTED | ||
| } else { | ||
| nm.areNotificationsEnabled() | ||
| } | ||
| val appCtx = context.applicationContext | ||
| val micGranted = | ||
| ContextCompat.checkSelfPermission(appCtx, Manifest.permission.RECORD_AUDIO) == | ||
| PackageManager.PERMISSION_GRANTED | ||
|
|
||
| if (!notifsGranted) { | ||
| Log.w(TAG, "Notifications not enabled - service will run without notification updates") | ||
| } | ||
| if (!micGranted) { | ||
| Log.d( | ||
| TAG, | ||
| "Microphone permission not granted. MicLockService will not start automatically.", | ||
| ) | ||
| return | ||
| } | ||
|
|
||
| // Only require microphone permission | ||
| if (micGranted) { | ||
| Log.d(TAG, "Microphone permission granted, scheduling service start via WorkManager") | ||
| scheduleAlarmMicStart(appCtx) | ||
| } | ||
|
|
||
| // Use WorkManager to start the service with a delay | ||
| // This avoids Android 15+ restrictions on starting foreground services from BOOT_COMPLETED | ||
| val workRequest = OneTimeWorkRequestBuilder<BootServiceWorker>() | ||
| .setInitialDelay(5, TimeUnit.SECONDS) | ||
| .build() | ||
| private fun scheduleAlarmMicStart(appCtx: Context) { | ||
| val svcIntent = | ||
| Intent(appCtx, MicLockService::class.java).apply { | ||
| action = MicLockService.ACTION_START_USER_INITIATED | ||
| } | ||
|
|
||
| WorkManager.getInstance(context) | ||
| .enqueue(workRequest) | ||
| val piFlags = | ||
| PendingIntent.FLAG_UPDATE_CURRENT or | ||
| (if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) { | ||
| PendingIntent.FLAG_IMMUTABLE | ||
| } else { | ||
| 0 | ||
| }) | ||
|
|
||
| Log.d(TAG, "WorkManager task scheduled to start MicLockService") | ||
| val pi: PendingIntent = | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||
| PendingIntent.getForegroundService( | ||
| appCtx, | ||
| ALARM_REQUEST_CODE, | ||
| svcIntent, | ||
| piFlags, | ||
| ) | ||
| } else { | ||
| Log.d( | ||
| TAG, | ||
| "Microphone permission not granted. MicLockService will not start automatically.", | ||
| PendingIntent.getService(appCtx, ALARM_REQUEST_CODE, svcIntent, piFlags) | ||
| } | ||
|
|
||
| val am = appCtx.getSystemService(Context.ALARM_SERVICE) as AlarmManager | ||
| val triggerElapsed = SystemClock.elapsedRealtime() + DELAY_MILLIS | ||
|
|
||
| try { | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { | ||
| am.setAndAllowWhileIdle( | ||
| AlarmManager.ELAPSED_REALTIME_WAKEUP, | ||
| triggerElapsed, | ||
| pi, | ||
| ) | ||
| } else { | ||
| @Suppress("DEPRECATION") | ||
| am.set(AlarmManager.ELAPSED_REALTIME_WAKEUP, triggerElapsed, pi) | ||
| } | ||
| Log.d(TAG, "Scheduled mic FGS via alarm + getForegroundService in ${DELAY_MILLIS}ms") | ||
| } catch (e: Exception) { | ||
| Log.e(TAG, "Alarm schedule failed; trying direct startForegroundService", e) | ||
| try { | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||
| ContextCompat.startForegroundService(appCtx, svcIntent) | ||
| } else { | ||
| appCtx.startService(svcIntent) | ||
| } | ||
| } catch (e2: Exception) { | ||
| Log.e(TAG, "Direct startForegroundService also failed", e2) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| companion object { | ||
| private const val TAG = "BootCompletedReceiver" | ||
| private const val ALARM_REQUEST_CODE = 0x4D434C42 // 'MCB' | ||
|
|
||
| /** Elapsed realtime delay so boot / unlock / audio stack are ready. */ | ||
| private const val DELAY_MILLIS = 15_000L | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
MY_PACKAGE_REPLACEDintent-filter includes<data android:scheme="package" />, which narrows matching to only intents that include data.Intent.ACTION_MY_PACKAGE_REPLACEDbroadcasts are commonly sent without data; if so, this receiver will never fire on updates. Consider removing the<data>constraint (or verify the broadcast always includes matching data on your supported API levels).