Remove the orphaned hardwarelifecycle_edit.html template file #131
+0
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsenecal
changed the title
jsenecal
force-pushed
the
fix/custom-fields-121
branch
from
6adaa77 to
d827425
Compare
This template has been orphaned since commit 27dd090 (PR DanSheps#109) which removed the template_name reference from HardwareLifecycleEditView. Closes DanSheps#121 as outdated - the template was not being loaded.
jsenecal
force-pushed
the
fix/custom-fields-121
branch
from
d827425 to
0320bfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the orphaned
hardwarelifecycle_edit.htmltemplate file that has been unused since commit 27dd090 (PR #109).The
template_namereference was removed fromHardwareLifecycleEditViewin that commit when the form was updated to useTabbedGroupsfieldsets, but the template file itself was never deleted.This is just cleanup - the template was not being loaded.
Related Issue
Issue #121 will be closed as it is outdated - the reported problem cannot be replicated with the current code.