feat: Make end_of_sale and end_of_support dates optional #132
+181
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow creating HardwareLifecycle entries without specifying end_of_sale and end_of_support dates. This enables tracking devices that are still fully supported with no known end date. - Make end_of_sale and end_of_support nullable in model - Update API serializer with allow_null=True for all date fields - Add comprehensive tests for null date handling (API and forms) Fixes DanSheps#123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
end_of_saleandend_of_supportfields optional (nullable) in HardwareLifecycle model|placeholderfilter to templates to display "—" for null datesChanges
end_of_saleandend_of_supportnullable (blank=True, null=True)0017_optional_lifecycle_dates.pyrequired=False, allow_null=True|placeholderfilter for null date displayNotes
PostgreSQL sorts NULLs last by default for ascending order, so devices with unknown dates will appear at the end when sorting by date.
Fixes #123