Feature/c2019/w1/depression icd11 - #13
Conversation
…UAM/ecs-outcomes into bugfix/depression-c2011w3
* `use` command was unnecessarily added again in the `descriptives` chunk (raising an error) * There were extra unnecessary blank lines * variable label for `depression_12m` in table did not match the value in the output dataset * Value labels for the dichotomous variables were listed as "no/yes" in the table, instead of (sentence-case) "No/Yes" * Additional "wildcard" characters should have been deleted
…nmatching number of missing case (depression_lifetime & depression_life_proxy) by taking into acount the proxy caracter of answers
Also sets the width of the "variable information" table to 80 characters to (try) to avoid changes by the visual markdown editor
…m/CCOMS-UAM/ecs-outcomes into feature/c2019/w1/depression-icd11
There was a problem hiding this comment.
@Leafrancia please review the comments and changes requested. You can use the doc/checklist.md document as a guide if necessary.
|
I think the change requested are resolved with in the last commit |
|
@Leafrancia please review carefully my commits from today, and make sure you understand everything and you consider it correct. |
DaniMori
left a comment
DaniMori
left a comment
There was a problem hiding this comment.
Please review the link to the ICD11 page, then we're good to go I think
DaniMori
left a comment
DaniMori
left a comment
There was a problem hiding this comment.
Ok, everything's fine with these changes!
DaniMori
left a comment
DaniMori
left a comment
There was a problem hiding this comment.
That should do it. Did you see changes in the prevalence?
DaniMori
left a comment
DaniMori
left a comment
There was a problem hiding this comment.
Please use the encoding criteria stated in lines 124-134, and delete the code related to the "functional impairment"
| *# this criterion is 'missing'". | ||
| gen d_crit2 =0 | ||
| replace d_crit2 = 1 if q4233!=1 & q4225_causemed2!=1 | ||
| replace d_crit2 = . if q4233==. & q4225_causemed2==. |
There was a problem hiding this comment.
This section does not follow the criteria stated in the "Explanation" section. I'd rather you tried to code in an equivalent manner, but following those criteria (see lines 124-134, in this commit)
There was a problem hiding this comment.
Was it wrong to include proxy==2 btw? I think it would be safer to avoid the proxies from being recoded as "something else"... Are you sure the two syntaxes are not equivalent?
There was a problem hiding this comment.
Did you check whether it was ok or not to include proxy==2?
| *# the criterion negative." | ||
| gen d_crit3= 0 if q4224b==1 | q4225_causemed12==1 | q4225_causemed23==1 | q4225_causemed24==1 | q4225_causemed25==1 | q4225_causemed30==1 | q4225_causemed31==1 | ||
| replace d_crit3 = 1 if (q4224b==2) | (q4225_causemed12!=1 & q4225_causemed23!=1 & q4225_causemed24!=1 & q4225_causemed25!=1 & q4225_causemed30!=1 & q4225_causemed31!=1) | ||
| replace d_crit3=. if q4224==. & q4224a==. & q4224b==. |
There was a problem hiding this comment.
The same as before: This section does not follow the criteria stated in the "Explanation" section. I'd rather you tried to code in an equivalent manner, but following those criteria (see lines 124-134, in this commit)
Also, make sure the two syntaxes are not equivalent.
There was a problem hiding this comment.
Did you check whether the two syntaxes were equivalent?
There was a problem hiding this comment.
Please @Leafrancia use criteria explained; or if you don't explain why
DaniMori
left a comment
DaniMori
left a comment
There was a problem hiding this comment.
Please name the "criteria variables" (d_crit_4 and d_crit_5) correctly, according to the criterion number.
Also, please mind the other two comments, one of them to make sure the code is correct, the other one to improve clarity.
DaniMori
left a comment
DaniMori
left a comment
There was a problem hiding this comment.
Just put the comments in their place please, then we are done! :)
DaniMori
left a comment
DaniMori
left a comment
There was a problem hiding this comment.
Nice! However, there are still pending comments. Please go to the "Conversation" tab to see the open conversations.
2 participants
Please Dani, could you review this proposition of ICD11 code for the 2019w1 dataset?
Thank you in advance.