Skip to content

fix(android): update overlay color based on the UI mode of devices#45

Merged
DanielAraldi merged 4 commits into
mainfrom
fix/android-ui-mode
May 11, 2026
Merged

fix(android): update overlay color based on the UI mode of devices#45
DanielAraldi merged 4 commits into
mainfrom
fix/android-ui-mode

Conversation

@DanielAraldi

@DanielAraldi DanielAraldi commented May 11, 2026

Copy link
Copy Markdown
Owner

Summary 📋

Brief description of what was done.

Update overlay color based on the UI mode of devices.

React Native ⚛️

Detailed checklist of each change on the React Native side (If necessary).

  • Remove unnecessary mathematical logic from the downscaleFactor property.
  • Update documentation.
  • Update example App.

Android 🤖

Detailed checklist of each change on the Android side (If necessary).

  • Overrides onConfigurationChanged method to update overlay color based on the UI mode of devices.

iOS 🍎

Detailed checklist of each change on the iOS side (If necessary).

--

References 💬

Materials, links, and other resources used as references in the development process (If necessary).

@DanielAraldi DanielAraldi requested a review from Copilot May 11, 2026 18:00
@DanielAraldi DanielAraldi self-assigned this May 11, 2026
@DanielAraldi DanielAraldi added bug Something isn't working android Android only labels May 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Android blur overlay behavior to react to device UI mode (light/dark) changes, and simplifies the React Native-side downscaleFactor handling while updating documentation/examples accordingly.

Changes:

  • Android: Make overlay color resolution UI-mode-aware and refresh overlay color on configuration changes.
  • React Native: Remove downscaleFactor scaling logic and refactor how ref is passed to the native Blur component.
  • Docs/examples: Update TypeScript ref examples and adjust Android platform notes.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/BlurView.tsx Removes downscaleFactor scaling logic and moves ref passing into shared native props.
src/BlurTarget.tsx Updates example snippet to type the ref as useRef<View | null>(null).
README.md Updates Android platform behavior notes (radius/downscaleFactor discussion).
example/ios/Podfile.lock Updates the example iOS pod lock entry for BlurView to 2.3.1.
android/src/main/java/com/blurview/BlurView.kt Persists overlay type string and refreshes overlay color on configuration changes; updates overlay resolution to use configuration.
android/src/main/java/com/blurview/BlurOverlayColor.kt Makes overlay mapping UI-mode-aware by selecting light/dark variants for several blur types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment thread android/src/main/java/com/blurview/BlurView.kt
Comment thread android/src/main/java/com/blurview/BlurView.kt Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.

Comment thread src/BlurView.tsx
Comment thread README.md
Comment thread example/src/constants/blur.ts
Comment thread example/src/constants/blur.ts
Comment thread example/src/screens/Vibrancies/index.tsx
Comment thread example/src/screens/Settings/index.tsx
@DanielAraldi DanielAraldi marked this pull request as ready for review May 11, 2026 18:33
@DanielAraldi DanielAraldi merged commit 156e25a into main May 11, 2026
8 checks passed
@DanielAraldi DanielAraldi deleted the fix/android-ui-mode branch May 11, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android Android only bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants