Fix non-hygienic hazard in count_idents! macro#23
Open
RReverser wants to merge 1 commit intoDanielKeep:masterfrom
Open
Fix non-hygienic hazard in count_idents! macro#23RReverser wants to merge 1 commit intoDanielKeep:masterfrom
RReverser wants to merge 1 commit intoDanielKeep:masterfrom
Conversation
Fixed non-hygienic warning by using only identifiers from the original list - more specifically, matching the first identifier and moving it to the end of the enum; after that, we can take it as a known last value, increase by 1 and so get count of elements in the enum. Also changed `u32` to `usize` in `count_idents!` to match all the other examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed non-hygienic warning by using only identifiers from the original list - more specifically, matching the first identifier and moving it to the end of the enum; after that, we can take it as a known last value, increase by 1 and so get count of elements in the enum.
Also changed
u32tousizeincount_idents!to match all the other examples.