fix: exclude dummy interfaces from system interfaces list and ensure …#244
Open
DanielLavrushin wants to merge 3 commits into
Open
fix: exclude dummy interfaces from system interfaces list and ensure …#244DanielLavrushin wants to merge 3 commits into
DanielLavrushin wants to merge 3 commits into
Conversation
…they are included in monitoring options
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -9 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes interface discovery so Linux dummy* interfaces (e.g., dummy0) appear in Settings interface selectors (monitoring / NAT masquerade), instead of being filtered out.
Changes:
- Stop excluding
dummy*interfaces via the “virtual/internal” exclude-prefix list. - Treat
dummy*as an allowed interface prefix even when it has no IP assigned (host mode), so it still shows up in selectors. - Document the fix in
changelog.mdas1.66.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/http/handler/config.go |
Adjusts interface filtering rules to include dummy* interfaces in the returned interface list. |
changelog.md |
Adds a 1.66.1 entry describing the dummy-interface list fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
| - FIXED: **b4 would not start on some Asus Merlin routers** - on certain firmware (for example the MerlinWRT) b4 quit right after starting and showed a confusing message about a missing `xt_connbytes` feature, even though the router actually supported it. The real cause was b4 using a newer firewall command option that the router's built-in tool did not understand. b4 now adapts to the router's own tools automatically, so it starts normally with nothing extra to install. | ||
| - FIXED: **Telegram no longer disconnects with a "proxy is not configured correctly" message after sitting idle** - when a Telegram connection through b4 was left idle for a while, your network could quietly drop it in the background, and Telegram would show "The proxy you are using is not configured correctly and will be disabled" even though the proxy was working fine. b4 now keeps these connections alive on its own, so they stay open and reconnect cleanly instead of being dropped. | ||
| - FIXED: **Connections page showed nothing when the device clock was out of sync** - the time filter (30s / 1m / 5m / 15m) and the per-connection activity graph compared the live data against the browser's own clock, so a computer whose clock was off by even ~30 seconds could see an empty list and empty activity bars. Filtering and the activity graph now use the timestamps in the connection data itself, so they work regardless of the device clock or its timezone. | ||
| - FIXED: **b4 would not start on some Asus Merlin routers** - on certain firmware (for example the MerlinWRT) b4 quit right after starting and showed a confusing message about a missing `xt_connbytes` feature, even though the router actually supported it. The real cause was b4 using a newer firewall command option that the router's built-in tool did not understand. b4 now adapts to the router's own tools automatically, so it starts normally with nothing extra to install.- FIXED: **Connections page showed nothing when the device clock was out of sync** - the time filter (30s / 1m / 5m / 15m) and the per-connection activity graph compared the live data against the browser's own clock, so a computer whose clock was off by even ~30 seconds could see an empty list and empty activity bars. Filtering and the activity graph now use the timestamps in the connection data itself, so they work regardless of the device clock or its timezone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…they are included in monitoring options