Update our copy of the released Homebrew formula #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: github action <[email protected]>
DanilaFe
pushed a commit
that referenced
this pull request
Mar 31, 2025
Unfortunately, my previous attempt to modify get_string() failed to
realize how broadly it's used, and as a result, it broke a few other
tests ('extern/bradc/require/requireNonString.chpl' and
'library/packages/UnitTest/PrimitivesError/GetByName_WrongArgs.chpl').
Here, I've reverted that change and specialzed the logic that converts
arg #2 in a PRIM_GET_MEMBER[_VALUE] call to handle both string
literals and literal VarSymbol*'s that refer directly to fields.
Is this too specialized / distinct from this PR? Should I just give
up and use a C string literal instead? Perhaps, but it feels really
regrettable to me that we're still relying on that pattern in the IR,
so this is my baby step to try and not contribute to continuing that
practice. With more effort, we could probably/possibly convert more
creations of these expressions to use the field directly, but that
would definitely feel like a step too far for this PR.
---
Signed-off-by: Brad Chamberlain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homebrew released formula file hash is d5c90c111a8cc7cbd55ecb669565a88ce64faa608e01688ee549addf9d09732d. Created by Github action