fix: Uncaught ESRCH on SIGINT/SIGTERM
#370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian6932
force-pushed
the
fix/clean-exit
branch
2 times, most recently
from
621bbb0 to
1fa7f1c
Compare
brian6932
force-pushed
the
fix/clean-exit
branch
from
1fa7f1c to
9ddfc18
Compare
Danny-Dasilva
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #256
Also addresses my complaint in #256 (comment), a library shouldn't be exiting the process, there may be multiple callbacks sent on these signals (
process.exitdoesn't care), the last one should be the client, not the library.