Add player trade command (`/wp trade <playerName>`) by Copilot · Pull Request #298 · Dans-Plugins/Wild-Pets

Copilot · 2026-03-08T09:22:11Z

Original prompt

This section details on the original issue you should resolve

<issue_title>Player Trade Feature</issue_title>
<issue_description>A player option to "Trade" a pet to another player. My player's want pets that they can sell to each other. A simple Trade feature would work and then the players can use our pay features we already have to settle payment on their own. (I did see there was a type of "release" command already, but a trade option would simplify things in my opinion. At least for this purpose.)</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Player Trade Feature #246

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

… consistency Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Copilot

Pull request overview

Adds a new /wp trade <playerName> subcommand to transfer ownership of the caller’s currently selected pet to another online player, updating both in-memory pet lists and persisted pet records.

Changes:

Introduces TradeCommand to validate and perform pet ownership transfer, notify both players, and clear the sender’s selection.
Adds PetListRepository.transferPet() to move a pet between owners’ pet lists while preserving entity properties.
Wires the command into plugin initialization, help output, and permissions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/main/resources/plugin.yml	Adds `wp.trade` permission node.
src/main/java/dansplugins/wildpets/pet/list/PetListRepository.java	Adds `transferPet()` for moving pets between owners.
src/main/java/dansplugins/wildpets/commands/TradeCommand.java	New `/wp trade` command implementation.
src/main/java/dansplugins/wildpets/commands/HelpCommand.java	Adds trade command line to help output.
src/main/java/dansplugins/wildpets/WildPets.java	Registers `TradeCommand` in command initialization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-08T09:43:02Z

src/main/java/dansplugins/wildpets/pet/list/PetListRepository.java

+        PetList newList = getPetList(newOwnerUUID);
+        if (newList == null) {
+            createPetListForPlayer(newOwnerUUID);
+            newList = getPetList(newOwnerUUID);
+        }
+
+        pet.setOwnerUUID(newOwnerUUID);
+        pet.removeFromAccessList(oldList.getOwnerUUID());
+        pet.addToAccessList(newOwnerUUID);
+        newList.addPet(pet);
+        return true;


transferPet allows bypassing the configured petLimit (currently only enforced during taming). A player can trade pets to someone who is already at the limit, exceeding the cap. Add a limit check against configService.getInt("petLimit") before adding to the recipient list (and return false with a meaningful failure path).

Copilot · 2026-03-08T09:43:02Z

src/main/java/dansplugins/wildpets/commands/TradeCommand.java

+        String targetName = args[0];
+        Player targetPlayer = Bukkit.getPlayer(targetName);
+
+        if (targetPlayer == null) {
+            player.sendMessage(ChatColor.RED + "That player is not online.");
+            return false;


Bukkit.getPlayer(String) performs partial name matching and can return the wrong player if multiple online names share a prefix. For a trade/ownership transfer, use Bukkit.getPlayerExact(targetName) (or otherwise disambiguate) to avoid transferring a pet to an unintended player.

Copilot · 2026-03-08T09:43:02Z

src/main/java/dansplugins/wildpets/commands/TradeCommand.java

+        Pet pet = ephemeralData.getPetSelectionForPlayer(player.getUniqueId());
+        if (pet == null) {
+            player.sendMessage(ChatColor.RED + "No pet selected. Use /wp select first.");
+            return false;
+        }
+
+        if (args.length < 1) {
+            return execute(sender);
+        }
+


The missing-argument check happens after the selected-pet check, so /wp trade with no args can report "No pet selected" instead of showing usage. For consistency with commands like RenameCommand, validate args.length first (show usage), then validate selection/transfer prerequisites.

Suggested change

Pet pet = ephemeralData.getPetSelectionForPlayer(player.getUniqueId());

if (pet == null) {

player.sendMessage(ChatColor.RED + "No pet selected. Use /wp select first.");

return false;

}

if (args.length < 1) {

return execute(sender);

}

if (args.length < 1) {

return execute(sender);

}

Pet pet = ephemeralData.getPetSelectionForPlayer(player.getUniqueId());

if (pet == null) {

player.sendMessage(ChatColor.RED + "No pet selected. Use /wp select first.");

return false;

}

dmccoystephenson · 2026-03-08T09:44:59Z

@copilot address comments

… check Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Copilot · 2026-03-08T09:46:30Z

@copilot address comments

All three review comments addressed in 86b1d14:

Reordered validation so args.length is checked before pet selection (shows usage instead of "no pet selected" when args missing)
Switched from Bukkit.getPlayer() to Bukkit.getPlayerExact() to avoid partial name matching
Added petLimit check in transferPet() that prevents exceeding the configured cap and rolls back the removal if the recipient is at their limit

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-21T17:52:34Z

src/main/java/dansplugins/wildpets/pet/list/PetListRepository.java

+    public boolean transferPet(Pet pet, UUID newOwnerUUID) {
+        PetList oldList = getPetList(pet.getOwnerUUID());
+        if (oldList == null || !oldList.getPets().remove(pet)) {


Pet exposes getOwnerUUID(), but this new code calls pet.getOwnerUUID() (missing UUID). This won't compile and will prevent the plugin from building. Update the call to use the correct method name.

Initial plan

b316b44

Copilot AI assigned Copilot and dmccoystephenson Mar 8, 2026

Copilot started work on behalf of dmccoystephenson March 8, 2026 09:22 View session

Copilot AI and others added 2 commits March 8, 2026 09:26

Add player trade command for transferring pets between players

1822eae

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Address code review: remove old owner from access list, fix help text…

7e81f22

… consistency Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add player trade feature for pets~~ Add player trade command (/wp trade <playerName>) Mar 8, 2026

Copilot finished work on behalf of dmccoystephenson March 8, 2026 09:29

dmccoystephenson requested a review from Copilot March 8, 2026 09:39

Copilot started reviewing on behalf of dmccoystephenson March 8, 2026 09:40 View session

Copilot AI reviewed Mar 8, 2026

View reviewed changes

Copilot started work on behalf of dmccoystephenson March 8, 2026 09:45 View session

Address review: reorder args check, use getPlayerExact, add pet limit…

86b1d14

… check Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Copilot finished work on behalf of dmccoystephenson March 8, 2026 09:46

dmccoystephenson marked this pull request as ready for review March 8, 2026 09:57

dmccoystephenson requested a review from Copilot March 21, 2026 17:47

Copilot started reviewing on behalf of dmccoystephenson March 21, 2026 17:47 View session

Copilot AI reviewed Mar 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add player trade command (`/wp trade <playerName>`)#298

Add player trade command (`/wp trade <playerName>`)#298
Copilot wants to merge 4 commits intomainfrom
copilot/add-player-trade-feature

Copilot AI commented Mar 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

dmccoystephenson commented Mar 8, 2026

Uh oh!

Copilot AI commented Mar 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

dmccoystephenson commented Mar 8, 2026

Uh oh!

Copilot AI commented Mar 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 8, 2026 •

edited

Loading