Move ninja from install_requires to setup_requires#50
Open
weiji14 wants to merge 1 commit intoDao-AILab:mainfrom
Open
Move ninja from install_requires to setup_requires#50weiji14 wants to merge 1 commit intoDao-AILab:mainfrom
weiji14 wants to merge 1 commit intoDao-AILab:mainfrom
Conversation
Set `ninja` as build time dependency rather than runtime dependency.
10 tasks
jeongseok-meta
added a commit
to jeongseok-meta/staged-recipes
that referenced
this pull request
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
ninjaas build time dependency rather than runtime dependency.Xref https://github.com/conda-forge/staged-recipes/pull/29821/files#r2066577425 where we're trying to package
causal-conv1don conda-forge, and would like the setup.py metadata to be correct so that runningpip checkwould work.Similar case to Dao-AILab/flash-attention#937.