-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update allow list #44783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update allow list #44783
Conversation
Signed-off-by: Vigilans <[email protected]>
Summary of ChangesHello @Vigilans, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's allow list by incorporating a new entry for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the image allow list to include an entry for Flannel from ghcr.io. My review focuses on security best practices for the allow list. I've suggested making the new entry more specific to enhance security by adhering to the principle of least privilege. This is a minor change but improves the overall security posture.
| ghcr.io/fief-dev/fief | ||
| ghcr.io/fish2018/pansou-web | ||
| ghcr.io/fission/** | ||
| ghcr.io/flannel-io/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For enhanced security, it's better to specify the exact image name instead of using a wildcard. This adheres to the principle of least privilege. By using ghcr.io/flannel-io/flannel, you only allow the intended image, reducing the risk from other potentially unwanted images that could be published under the flannel-io organization.
ghcr.io/flannel-io/flannel
No description provided.