fix: node_info label for erigon_get_header_by_number (#12346) by Dargon789 · Pull Request #221 · Dargon789/foundry

Dargon789 · 2025-10-29T07:15:45Z

Motivation

Solution

PR Checklist

Added Tests
Added Documentation
Breaking changes

Summary by Sourcery

Bug Fixes:

Update the node_info macro argument from "ots_getApiLevel" to "erigon_getHeaderByNumber"

codesandbox · 2025-10-29T07:15:49Z

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

sourcery-ai · 2025-10-29T07:15:52Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fix the node_info macro invocation by updating its label to the correct erigon_getHeaderByNumber RPC method name.

Class diagram for EthApi method update

classDiagram
    class EthApi {
        +block_by_number(number: BlockNumber): Result<Option<AnyRpcBlock>>
        +"get_header_by_number(number: BlockNumber): Result<Option<AnyRpcBlock>>"
    }

File-Level Changes

Change	Details	Files
Correct node_info label for the Erigon get-header-by-number call	Replaced the old node_info!("ots_getApiLevel") invocation with node_info!("erigon_getHeaderByNumber")	`crates/anvil/src/eth/otterscan/api.rs`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

vercel · 2025-10-29T07:15:52Z

@phrwlk is attempting to deploy a commit to the Foundry development Team on Vercel.

A member of the Team first needs to authorize it.

snyk-io · 2025-10-29T07:15:55Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

gemini-code-assist · 2025-10-29T07:15:58Z

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important fix by correcting an internal logging label. The change ensures that the node_info output accurately identifies the specific RPC method being handled, improving the clarity and correctness of diagnostic information for the erigon_getHeaderByNumber call.

Highlights

Logging Label Correction: The node_info! label within the EthApi implementation for otterscan/api.rs has been updated to accurately reflect the erigon_getHeaderByNumber RPC method being processed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

vercel · 2025-10-29T07:16:43Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
next	Ready	Preview	Comment	Oct 29, 2025 7:16am

gemini-code-assist

Code Review

This pull request correctly fixes a copy-paste error in a logging macro within the erigon_get_header_by_number function. The change is accurate and improves the correctness of log outputs. I've added one comment with a suggestion to improve the clarity and correctness of the function where the change was made.

gemini-code-assist · 2025-10-29T07:17:54Z

        number: BlockNumber,
    ) -> Result<Option<AnyRpcBlock>> {
-        node_info!("ots_getApiLevel");
+        node_info!("erigon_getHeaderByNumber");


While this change correctly fixes the logging output for this function, the function's implementation seems to have a discrepancy with its name and the Erigon RPC specification.

The function erigon_get_header_by_number is expected to return only a block header, but its return type is Result<Option<AnyRpcBlock>> and it returns a full block object (with transaction hashes).

Other functions in this file, like ots_get_block_details, have comments explaining why they deviate from the spec for simplicity. If returning a full block here is intentional, it would be beneficial to add a similar comment to this function to clarify the behavior and avoid confusion.

For example:

/// For simplicity purposes, we return the entire block instead of only the header. /// This is the original purpose of the endpoint (to save bandwidth), but it doesn't seem /// necessary in the context of an anvil node.

Alternatively, if the intention is to adhere to the spec, the function could be updated to return only the header (AnyRpcHeader).

fix: node_info label for erigon_get_header_by_number (#12346)

de2adb9

sourcery-ai Bot approved these changes Oct 29, 2025

View reviewed changes

vercel Bot deployed to Preview October 29, 2025 07:16 View deployment

Dargon789 merged commit 60a7a33 into Dargon789:dargon789/gamefi Oct 29, 2025
3 of 5 checks passed

gemini-code-assist Bot reviewed Oct 29, 2025

View reviewed changes

This was linked to issues Oct 31, 2025

#### Sequence diagram for decoding a revert reason #60

Open

Fix: Bug from Sequence Contracts Standard Library (ERC20, ERC721, ERC1155) #180

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: node_info label for erigon_get_header_by_number (#12346)#221

fix: node_info label for erigon_get_header_by_number (#12346)#221
Dargon789 merged 1 commit into
Dargon789:dargon789/gamefifrom
foundry-rs:master

Dargon789 commented Oct 29, 2025 •

edited by sourcery-ai Bot

Loading

Uh oh!

codesandbox Bot commented Oct 29, 2025

Uh oh!

sourcery-ai Bot commented Oct 29, 2025 •

edited

Loading

Reviewer's Guide

Class diagram for EthApi method update

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

vercel Bot commented Oct 29, 2025

Uh oh!

snyk-io Bot commented Oct 29, 2025

Uh oh!

gemini-code-assist Bot commented Oct 29, 2025

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

vercel Bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Dargon789 commented Oct 29, 2025 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Solution

PR Checklist

Summary by Sourcery

Uh oh!

codesandbox Bot commented Oct 29, 2025

Review or Edit in CodeSandbox

Uh oh!

sourcery-ai Bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Class diagram for EthApi method update

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

vercel Bot commented Oct 29, 2025

Uh oh!

snyk-io Bot commented Oct 29, 2025

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

gemini-code-assist Bot commented Oct 29, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

vercel Bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dargon789 commented Oct 29, 2025 •

edited by sourcery-ai Bot

Loading

sourcery-ai Bot commented Oct 29, 2025 •

edited

Loading

vercel Bot commented Oct 29, 2025 •

edited

Loading