Add minimum sightings filter and AP estimation enhancements - #1
Open
MatthieuGrr wants to merge 1 commit into
Open
Add minimum sightings filter and AP estimation enhancements#1MatthieuGrr wants to merge 1 commit into
MatthieuGrr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this tool, it's exactly what I was looking for. Two things I added while using it on my own captures:
Min sightings per BSSID (Filters). A slider to hide networks seen fewer than N times,
to get rid of drive-by noise. Counts are based on the current selection, so they follow
the other filters.
Estimate every shown network at once (AP Locator). Same estimation as the existing
per-AP option, but applied to everything shown, one pin per BSSID. Clicking a pin still
drills into it like before.
A few notes:
pin doesn't move when you click into it. Estimates are cached, otherwise dragging a
slider re-runs trilateration on every AP.
wardrive_estimated_aps.csvand has 4 extra columns. Normal export is unchanged.focusAP()was passing""for records with no BSSID, whichmerged all of them into one bogus AP. Both call sites now use a shared
bssidKey().Single file, +140/-22, no new dependencies. Happy to split it in two PRs if you prefer.