Skip to content

Fix: Update DatasetVisualization props for new session flow - #423

Merged
cristian-tamblay merged 1 commit into
developfrom
fix/fix-new-session-button
Jan 21, 2026
Merged

Fix: Update DatasetVisualization props for new session flow#423
cristian-tamblay merged 1 commit into
developfrom
fix/fix-new-session-button

Conversation

@Creylay

@Creylay Creylay commented Jan 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR updates the props passed to the DatasetVisualization component in ModelsContent.jsx to match the expected prop names. The previous implementation used outdated prop names (onSessionCreated, onNewSession, existingSessions, tasks), which caused the "New Session" button and related features to not work. Now, the correct props (onItemCreated, onNewItem, existingItems, newItemButtonText) are used, restoring the intended functionality.

Type of Change

Check all that apply like this [x]:

  • Backend change
  • Frontend change
  • CI / Workflow change
  • Build / Packaging change
  • Bug fix
  • Documentation

Changes (by file)

  • DashAI/front/src/pages/models/ModelsContent.jsx
    • Updated the props passed to the DatasetVisualization component to use the correct names (onItemCreated, onNewItem, existingItems, newItemButtonText) instead of the outdated ones. This fixes the "New Session" button and related functionality.

Testing

  • Manually verified that clicking "New Session" in the dataset view now triggers the session creation flow as expected.

@cristian-tamblay
cristian-tamblay merged commit b6f78ef into develop Jan 21, 2026
18 checks passed
@cristian-tamblay
cristian-tamblay deleted the fix/fix-new-session-button branch January 21, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants