Fix EDA metadata toggle cut off in Save as Dataset modal - #753
Merged
Conversation
…d adjusting scroll behavior
cristian-tamblay
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Compute extended metadata (EDA)" toggle in the Save as Dataset modal was getting cut off as more converters were added. Fixed by separating the static form fields (note, name, EDA toggle) from the converter list, making only the list scrollable.
Type of Change
Check all that apply like this [x]:
Changes (by file)
DashAI/front/src/components/notebooks/datasetCreation/SaveDatasetModal.jsx: split the single scrollable content box into a static section (flexShrink: 0) for note, dataset name field, EDA toggle, and transformations heading, and a separate scrollable section (flex: 1,minHeight: 0,overflowY: auto) for the converter list.Testing (optional)
Open the Save as Dataset modal in the Notebooks view with several converters applied. Verify that the "Compute extended metadata (EDA)" card is always fully visible and that the converter list scrolls independently when there are many entries.