Fix regression prediction crashes - #855
Merged
Merged
Conversation
cristian-tamblay
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Predicting with a trained regression model crashed in two different, unrelated ways depending on which estimator was used. First, saving the results always inherited the target column's original type from the training dataset, so if that column happened to be integer-valued, PyArrow refused to cast a genuinely fractional prediction (e.g.
6.87) intoint64. Second, some estimators (e.g.LinearRegression) returned 2D(n, 1)predictions instead of 1D(n,)because the training target was fed to.fit()as a single-column DataFrame instead of a flat array. Tree/ensemble estimators likeAdaBoostRegressorsilently flattened this internally, but linear estimators preserved the 2D shape, and the dataset-saving step only accepts 1D arrays.Type of Change
Check all that apply like this [x]:
Changes (by file)
DashAI/back/job/predict_job.py: when saving prediction results, force the output column's schema toFloatforRegressionTaskinstead of inheriting the training dataset's original (possiblyInteger) column type, so fractional predictions no longer fail PyArrow's cast.DashAI/back/models/scikit_learn/sklearn_like_model.py: squeeze the training target to a 1-DSeriesbefore calling.fit(), so every scikit-learn estimator (not just the ones that flatten it internally) trains and predicts with a consistent 1-D shape.Testing
LinearRegression) and confirmed both are resolved after.tests/back/models/test_tabular_class_models.py,tests/back/api/test_predict_api.py, andtests/back/api/test_model_session_api.py. All pass, confirming classification models (which share the same base class) are unaffected.