configs/config.novacustom_v5*: enable ec update on all novacustom mtl… #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipleple
requested changes
May 14, 2025
Member
filipleple
left a comment
filipleple
left a comment
There was a problem hiding this comment.
The order of adding options to defconfigs matters, at least to our CI. Please take a look and fix: https://github.com/Dasharo/coreboot/actions/runs/14997955622/job/42136879437?pr=669
Contributor
Author
|
@filipleple alright i was not aware of that, thanks. Now it should work. |
mkopec
approved these changes
May 15, 2025
Member
mkopec
left a comment
mkopec
left a comment
There was a problem hiding this comment.
Please squash commits and add an Upstream-Status tag to the commit message
wiktormowinski
force-pushed
the
enable-ec-update-option-novacustom
branch
from
1384dec to
de6f63d
Compare
mkopec
approved these changes
May 15, 2025
wiktormowinski
force-pushed
the
enable-ec-update-option-novacustom
branch
2 times, most recently
from
cf5b1e8 to
d513373
Compare
… platforms Signed-off-by: Wiktor Mowinski <[email protected]>
Signed-off-by: Wiktor Mowinski <[email protected]>
Signed-off-by: Wiktor Mowinski <[email protected]>
mkopec
force-pushed
the
enable-ec-update-option-novacustom
branch
from
d513373 to
4e4e467
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… platforms