Skip to content

Add better line break issue handling. #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
woodhull wants to merge 5 commits into
base: main
Choose a base branch
from
+10 −0
Open

Add better line break issue handling. #295

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c8d144
Add better line break issue handling.
woodhull Oct 2, 2024
0c8612d
Merge branch 'Data-Liberation-Front:main' into main
woodhull Jan 1, 2025
867a256
Update csvlint.gemspec ruby version requirement
woodhull Jan 1, 2025
d50ec4c
Merge branch 'Data-Liberation-Front:main' into main
woodhull Mar 13, 2025
682408b
use match? to avoid issue
woodhull Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/csvlint/validate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,16 @@ def fetch_error(error)
rescue
nil
end

if message.match(/^Unquoted fields do not allow new line/i)
return :line_breaks
end

if message.match(/^New line must be/i)
return :inconsistent_line_breaks
end
Copy link
Contributor

@D-system D-system Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I read the linter correctly .match does not return a boolean therefore it is creating a object for nothing.
To fix it, we should use .match?.

Suggested change
if message.match(/^Unquoted fields do not allow new line/i)
return :line_breaks
end
if message.match(/^New line must be/i)
return :inconsistent_line_breaks
end
if message.match?(/^Unquoted fields do not allow new line/i)
return :line_breaks
end
if message.match?(/^New line must be/i)
return :inconsistent_line_breaks
end

Copy link
Member

@Floppy Floppy Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're probably right, yes!



ERROR_MATCHERS.fetch(message, :unknown_error)
end

Expand Down