Skip to content

Support Ruby 3.4 #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Support Ruby 3.4 #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
905095f
test and support Ruby 3.4
Floppy Jan 7, 2025
b8016b0
remove henry and use coveralls_reborn
Floppy Jan 14, 2025
9ce6cc3
add mutex_m dependency explicitly for ruby 3.4 and activesupport < 7.1
Floppy Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
ruby-version: ['2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3', '3.4']
activesupport-version:
- activesupport_5.2
- activesupport_6.0
Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
bundler-cache: true
ruby-version: "3.3"
ruby-version: "3.4"
- name: Install dependencies
run: bundle install
- name: Run the tests
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.3.0
3.4.1
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ A ruby gem to support validating CSV files to check their syntax and contents. Y

## Development

`ruby version 3.3`
`ruby version 3.4`

### Tests

Expand Down
6 changes: 3 additions & 3 deletions csvlint.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.required_ruby_version = [">= 2.5", "< 3.4"]
spec.required_ruby_version = [">= 2.5", "< 3.5"]

spec.add_dependency "csv"
spec.add_dependency "rainbow"
Expand All @@ -29,6 +29,7 @@ Gem::Specification.new do |spec|
spec.add_dependency "thor"
spec.add_dependency "rack"
spec.add_dependency "net-http-persistent"
spec.add_dependency "mutex_m" # For Ruby 3.4+

spec.add_development_dependency "bundler", ">= 1.3"
spec.add_development_dependency "rake"
Expand All @@ -40,13 +41,12 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "rspec"
spec.add_development_dependency "rspec-pride"
spec.add_development_dependency "rspec-expectations"
spec.add_development_dependency "coveralls"
spec.add_development_dependency "coveralls_reborn"
spec.add_development_dependency "byebug"
spec.add_development_dependency "github_changelog_generator"
spec.add_development_dependency "aruba"
spec.add_development_dependency "rdf", "< 4.0"
spec.add_development_dependency "rdf-turtle"
spec.add_development_dependency "henry"
spec.add_development_dependency "standardrb"
spec.add_development_dependency "appraisal"
end
Loading