Skip to content

Conversation

@pshapiro4broad
Copy link
Member

@pshapiro4broad pshapiro4broad commented Apr 30, 2025

Addresses

https://broadworkbench.atlassian.net/browse/DT-921

Summary

Add spotless to the maven configuration. See the spotless maven plugin docs.

  • when running locally, mvn compile will run spotless:apply
  • when running in CI (GitHub workflows), mvn verify (and therefore mvn test) will run spotless:check

This also removes the IntelliJ code format config files, and updates some GitHub workflows to use JDK 21, since that's the version our maven config specifies.

This change only enables spotless, no source reformatting has been applied yet. When we're ready to apply it, check out this branch and run mvn spotless:apply locally and push the changes up. Once the changes have been merged up, get the git hash and add it to a https://github.com/DataBiosphere/jade-data-repo/blob/develop/.git-blame-ignore-revs file.


Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - running this I do see a ton of changes, so it will be a rather large change once we tackle the actual cleanup. I also think semgrep will complain due to the number of query reformats.

@sonarqubecloud
Copy link

@kevinmarete kevinmarete closed this Oct 3, 2025
@kevinmarete kevinmarete reopened this Nov 4, 2025
@kevinmarete kevinmarete marked this pull request as ready for review November 4, 2025 18:30
@kevinmarete kevinmarete requested a review from a team as a code owner November 4, 2025 18:30
@kevinmarete kevinmarete requested review from eweitz, fboulnois and rushtong and removed request for a team and eweitz November 4, 2025 18:30
@kevinmarete kevinmarete self-assigned this Nov 4, 2025
@kevinmarete kevinmarete changed the title DT-921: Add spotless formatting to consent code base [DT-921] Add spotless formatting to consent code base Nov 4, 2025
@kevinmarete kevinmarete changed the title [DT-921] Add spotless formatting to consent code base [DT-921] Add spotless formatting to code base Nov 4, 2025
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@pshapiro4broad
Copy link
Member Author

This PR is incomplete, you still need to

  • run mvn compile locally and commit the 400+ files that are reformatted
  • update the test workflow to run mvn spotless:check so incorrectly formatted code merged up

@kevinmarete kevinmarete requested a review from rushtong November 4, 2025 20:44
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2025

@kevinmarete kevinmarete merged commit f132bc2 into develop Nov 5, 2025
14 checks passed
@kevinmarete kevinmarete deleted the ps/spotless branch November 5, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants