-
Notifications
You must be signed in to change notification settings - Fork 2
[DT-921] Add spotless formatting to code base #2508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nnning in CI (github workflows), use spotless check.
rushtong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - running this I do see a ton of changes, so it will be a rather large change once we tackle the actual cleanup. I also think semgrep will complain due to the number of query reformats.
|
# Conflicts: # pom.xml
…nnning in CI (github workflows), use spotless check.
…into ps/spotless
rushtong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
|
This PR is incomplete, you still need to
|
rushtong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
|



Addresses
https://broadworkbench.atlassian.net/browse/DT-921
Summary
Add spotless to the maven configuration. See the spotless maven plugin docs.
mvn compilewill runspotless:applymvn verify(and thereforemvn test) will runspotless:checkThis also removes the IntelliJ code format config files, and updates some GitHub workflows to use JDK 21, since that's the version our maven config specifies.
This change only enables spotless, no source reformatting has been applied yet. When we're ready to apply it, check out this branch and run
mvn spotless:applylocally and push the changes up. Once the changes have been merged up, get the git hash and add it to a https://github.com/DataBiosphere/jade-data-repo/blob/develop/.git-blame-ignore-revs file.Have you read CONTRIBUTING.md lately? If not, do that first.