-
Notifications
You must be signed in to change notification settings - Fork 0
chore!: upgrade non-breaking dependencies compatible with next.js 14 and react 18 (#752) #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: fran/714-nextjs-upgrade
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades multiple development and peer dependencies to newer versions while maintaining compatibility with Next.js 14 and React 18. The changes include major version bumps for several dev tools and minor/patch updates for peer dependencies.
Key changes:
- Upgraded multiple devDependencies including commitlint (v17→v20), eslint-config-prettier (v8→v10), eslint-plugin-jsdoc (v48→v61), and various other ESLint plugins and testing libraries
- Updated peer dependencies including Material-UI v7, Emotion, TanStack libraries, and other runtime dependencies
- Corrected placement of an eslint-disable comment in
getFacetedMinMaxValues.tsto properly target the callback function
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/Table/featureOptions/facetedColumn/getFacetedMinMaxValues.ts |
Moved eslint-disable comment to correctly target the callback function with cognitive complexity |
package.json |
Updated devDependencies (commitlint, storybook, testing-library, eslint plugins, prettier) and peerDependencies (@emotion, @mui, @TanStack, yup) to newer versions |
Closes #752.
This pull request primarily updates dependencies in the
package.jsonfile to newer versions, improving compatibility, security, and access to the latest features and bug fixes. Additionally, a minor code comment adjustment was made in thegetFacetedMinMaxValues.tsfile.Dependency updates:
devDependenciesinpackage.json, including@commitlint/cli,@storybook/nextjs-vite,@testing-library/react,eslint,prettier, and others, to their latest versions.peerDependenciesinpackage.json, such as@emotion/react,@mui/material,@tanstack/react-table,copy-to-clipboard,isomorphic-dompurify,react-dropzone, andreact-window, to newer versions.yupdependency inpackage.jsonfrom version^1.6.1to^1.7.1.Code maintenance:
src/components/Table/featureOptions/facetedColumn/getFacetedMinMaxValues.ts, moved theeslint-disable-next-linecomment to a more appropriate location for clarity.