feat: collapsible terrasetupform with opt-in prop (#921)#922
Merged
Conversation
Closes #921. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
45e8fc8 to
d5a987d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in “collapse/dismiss” affordance for the Terra onboarding wizard (TerraSetUpForm) by introducing an in-memory UI state provider and wiring it into the existing Terra provider tree. This keeps collapse state across SPA navigation while resetting on full reload (no browser storage).
Changes:
- Introduces a reusable
CollapseProvidercontext with{ isIn, onChange }state shape. - Adds
TerraSetUpUIProvider(Terra-specific wrapper) and mounts it insideTerraProfileProvider. - Updates
TerraSetUpFormto accept acollapsible?: booleanprop, render a toggle button, and wrap steps in MUI<Collapse>; adds Storybook stories for both modes.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/common/Collapse/provider/context.ts | Adds generic collapse context defaults. |
| src/components/common/Collapse/provider/hook.ts | Adds useCollapse hook for consuming collapse state. |
| src/components/common/Collapse/provider/provider.tsx | Adds CollapseProvider to manage in-memory collapse state (render-prop supported). |
| src/components/common/Collapse/provider/types.ts | Adds types for collapse context/provider props. |
| src/terra/provider.tsx | Wraps TerraProfileProvider children with TerraSetUpUIProvider. |
| src/terra/setUpUI/provider/context.ts | Adds Terra set-up UI context defaults. |
| src/terra/setUpUI/provider/hook.ts | Adds useTerraSetUpUI hook. |
| src/terra/setUpUI/provider/provider.tsx | Adds Terra set-up UI provider backed by CollapseProvider. |
| src/terra/setUpUI/provider/types.ts | Defines TerraSetUpUIContextValue shape. |
| src/components/Export/components/ExportToTerra/components/TerraSetUpForm/types.ts | Introduces TerraSetUpFormProps with collapsible flag. |
| src/components/Export/components/ExportToTerra/components/TerraSetUpForm/terraSetUpForm.tsx | Implements collapsible behavior + header toggle integration. |
| src/components/Export/components/ExportToTerra/components/TerraSetUpForm/terraSetUpForm.styles.ts | Refactors layout styles to support new header structure. |
| src/components/Export/components/ExportToTerra/components/TerraSetUpForm/components/Button/types.ts | Defines props for the new toggle button. |
| src/components/Export/components/ExportToTerra/components/TerraSetUpForm/components/Button/button.tsx | Implements “Save & continue later” / “Continue” toggle button. |
| src/components/Export/components/ExportToTerra/components/TerraSetUpForm/components/Button/button.styles.ts | Adds styling for the toggle button. |
| src/components/Export/components/ExportToTerra/components/TerraSetUpForm/components/FormStep/formStep.tsx | Adjusts imports to match refactored step styling structure. |
| src/components/Export/components/ExportToTerra/components/TerraSetUpForm/components/FormStep/formStep.styles.ts | Reworks step container styling after removing the old shared section styles. |
| src/components/Export/components/ExportToTerra/components/TerraSetUpForm/stories/args.ts | Adds mock auth/profile args for Storybook. |
| src/components/Export/components/ExportToTerra/components/TerraSetUpForm/stories/constants.ts | Adds Storybook boolean control list. |
| src/components/Export/components/ExportToTerra/components/TerraSetUpForm/stories/terraSetUpForm.stories.tsx | Adds stories for collapsible vs non-collapsible form variants. |
Comments suppressed due to low confidence (1)
src/components/common/Collapse/provider/provider.tsx:16
- New collapse state behavior is being introduced here but there are no accompanying Jest tests. There are existing tests for similar context providers (e.g.
tests/toggleButtonGroupProvider.test.tsx) that cover default state, initial state overrides, and toggling; adding analogous tests forCollapseProviderwould help prevent regressions.
export function CollapseProvider({
children,
initialState = false,
}: CollapseProviderProps): JSX.Element {
const [isIn, setIsIn] = useState<boolean>(initialState);
const onChange = useCallback(() => setIsIn((prev) => !prev), []);
return (
<CollapseContext.Provider value={{ isIn, onChange }}>
{typeof children === "function" ? children({ isIn, onChange }) : children}
</CollapseContext.Provider>
- add jsdoc to collapseprovider - add aria-expanded and aria-controls to terrasetupform toggle button - add tests for terrasetupuiprovider - fix self-import in terrasetupuiprovider to use relative path Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
NoopDog
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #921.
Adds an opt-in collapse/dismiss affordance to
TerraSetUpForm. Consumers passcollapsible: trueto render a "Save & continue later" / "Continue" toggle in the form header; the wizard's step list collapses via MUI<Collapse>. State is held in-memory in a React provider (nosessionStorage/localStorage), so it survives SPA navigation within a session and resets on full page reload, new tab, or browser close — matches the consuming app's session-only requirement.What changed
New generic
CollapseProvider(src/components/common/Collapse/provider/)Reusable collapse context —
{ isIn, onChange }shape with optional render-prop children. Mountable around any UI that needs in-memory collapse state.New
TerraSetUpUIProvider(src/terra/setUpUI/provider/)Terra-specific wrapper around
CollapseProviderthat exposes{ isOpen, onChange }semantically aligned with the form's open/closed UX. Mounted automatically insideTerraProfileProvider(src/terra/provider.tsx), so consumers don't wire it themselves.TerraSetUpForm(src/components/Export/.../TerraSetUpForm/)collapsible?: booleanprop (defaultfalse, non-breaking).<Stack direction="row" justify-content="space-between">housing the title block + toggle button.<Collapse in={collapsible ? isOpen : true}>— non-collapsible consumers see no behavioural change.Buttonsubcomponent renders the "Save & continue later" / "Continue" toggle; returnsnullwhencollapsibleis false.TerraSetUpFormPropsmoved to a localtypes.ts.Stories
Defaultstory renders the form withcollapsible: true.NotCollapsiblestory renders withcollapsible: false.AuthContext(isAuthenticated: true, status: SETTLED),TerraProfileContextwith three incomplete login statuses, andTerraSetUpUIProvider.Acceptance criteria
collapsibledefaults to false → existing render unchanged.collapsible: true: toggle button visible, collapse/expand works.sessionStorage/localStorage.TerraProfileProvider.collapsible: trueandcollapsible: falsevariants.Out of scope
Related
🤖 Generated with Claude Code