Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/copilot-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ This is a TypeScript library package (`@databiosphere/findable-ui`) that provide
## Key Project Information

- **Language**: TypeScript with strict mode enabled
- **Node Version**: 22.12.0 (enforced)
- **Node Version**: 22.13.0 (enforced)
- **UI Framework**: React 18 with Material-UI (MUI) v7
- **Build System**: TypeScript compiler (tsc)
- **Testing**: Jest with React Testing Library
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- uses: actions/setup-node@v4
if: ${{ steps.release.outputs.release_created }}
with:
node-version: "22.12.0"
node-version: "22.13.0"
registry-url: "https://registry.npmjs.org"
always-auth: true # Enable authentication for trusted publishing

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/run-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: "22.12.0"
node-version: "22.13.0"
cache: "npm"

- name: Install dependencies
Expand All @@ -41,7 +41,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: "22.12.0"
node-version: "22.13.0"
cache: "npm"

- name: Remove package lock
Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This is a TypeScript library package (`@databiosphere/findable-ui`) that provide

**Key Facts:**

- **Node Version:** 22.12.0 (enforced by package.json)
- **Node Version:** 22.13.0 (enforced by package.json)
- **UI Framework:** React 19 with Material-UI v7 and Emotion for styling
- **Build System:** TypeScript compiler (`tsc`) with strict mode enabled
- **Import Pattern:** External apps import as `@databiosphere/findable-ui/lib/<path>`
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Use `scripts/link.sh` to build and install a local copy of findable-ui
into a consuming project (e.g. ncpi-dataset-catalog, data-browser):

1. Clone this repository into the same parent folder as the consuming app.
2. Set `node` version to `22.12.0`.
2. Set `node` version to `22.13.0`.
3. Run `npm install` in both repositories.
4. From the consuming project directory:
```bash
Expand Down
2 changes: 1 addition & 1 deletion docs/TRUSTED_PUBLISHING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ The `id-token: write` permission enables the workflow to request OIDC tokens fro
```yaml
- uses: actions/setup-node@v4
with:
node-version: "22.12.0"
node-version: "22.13.0"
registry-url: "https://registry.npmjs.org"
always-auth: true # Enable authentication for trusted publishing
```
Expand Down
39 changes: 23 additions & 16 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { FlatCompat } from "@eslint/eslintrc";
import js from "@eslint/js";
import next from "eslint-config-next";
import sonarjs from "eslint-plugin-sonarjs";
import path from "node:path";
import { fileURLToPath } from "node:url";

Expand All @@ -15,28 +17,27 @@ const config = [
{
ignores: ["**/node_modules/**", "**/out/**", "**/.next/**", "lib/**"],
},
...next,
sonarjs.configs.recommended,
...compat.config({
extends: [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"prettier",
"plugin:prettier/recommended",
"plugin:storybook/recommended",
"next",
"plugin:sonarjs/recommended",
"plugin:eslint-comments/recommended",
"plugin:@eslint-community/eslint-comments/recommended",
],
parser: "@typescript-eslint/parser",
plugins: [
"@typescript-eslint",
"sonarjs",
"jsdoc",
"sort-destructure-keys",
"typescript-sort-keys",
"perfectionist",
"react-hooks",
],
rules: {
"eslint-comments/require-description": "error",
"@eslint-community/eslint-comments/require-description": "error",
"jsdoc/check-alignment": "error",
"jsdoc/check-param-names": "error",
"jsdoc/require-description": "error",
Expand All @@ -46,7 +47,23 @@ const config = [
"jsdoc/require-param-name": "error",
"jsdoc/require-returns": "error",
"jsdoc/require-returns-description": "error",
"perfectionist/sort-enums": "error",
"perfectionist/sort-interfaces": "error",
"react-hooks/exhaustive-deps": "error",
// The remaining react-hooks v7 rules below are React-Compiler-aware
// checks that surface real anti-patterns in the codebase. Disabled here
// to keep this PR scoped to the tooling upgrade; revisit alongside any
// future React Compiler adoption.
"react-hooks/immutability": "off",
"react-hooks/incompatible-library": "off",
"react-hooks/refs": "off",
"react-hooks/set-state-in-effect": "off",
"react-hooks/static-components": "off",
// sonarjs v1 dropped `cognitive-complexity` from its recommended preset
// (the rule's meta lost its `recommended` flag during the v1 rewrite,
// a discrepancy with the package README). Restore at default threshold
// 15 to preserve the coverage we had under v0.25.
"sonarjs/cognitive-complexity": ["error", 15],
"sort-destructure-keys/sort-destructure-keys": [
"error",
{ caseSensitive: false },
Expand All @@ -56,16 +73,6 @@ const config = [
"asc",
{ caseSensitive: true, minKeys: 2, natural: false },
],
"typescript-sort-keys/interface": [
"error",
"asc",
{ caseSensitive: false },
],
"typescript-sort-keys/string-enum": [
"error",
"asc",
{ caseSensitive: false },
],
},
}),
{
Expand Down
Loading
Loading