chore: remove redundant glob ^11.0.4 override (#940)#948
Merged
Conversation
The override was added in #705 (Dec 2025) to address transitive vulnerabilities flagged by npm audit at the time. Since Next.js has been bumped to 16, the transitive dep graph no longer contains the chains that pulled in those vulnerable versions — npm audit reports zero glob-related vulnerabilities at v7, v11, or v13 today. The override was also silently downgrading @joshwooding/vite-plugin-react-docgen-typescript from its declared glob ^13 to v11, and was adding one moderate finding to the audit that disappears when the override is removed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a now-redundant glob npm override from package.json (originally added to address Next.js 14-era audit findings) and refreshes the lockfile to reflect the natural, override-free dependency resolution under Next.js 16. It also updates the README to guide downstream consumers who may still carry the old override.
Changes:
- Remove
overrides: { glob: "^11.0.4" }frompackage.json. - Regenerate
package-lock.jsonto reflect override-freeglobresolution (notably allowing Jest’s transitiveglob@7.xagain and allowing newer consumers to useglob@13.x). - Add README guidance for consumers to remove the stale override.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Adds consumer guidance on removing the stale glob override (and expected install warnings). |
| package.json | Removes the glob override block. |
| package-lock.json | Updates the resolved dependency graph after removing the override. |
- scope vulnerability claim to specific resolved versions + date - mention both glob@7.x and inflight@1.0.6 deprecation warnings Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
NoopDog
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overrides: { glob: "^11.0.4" }block frompackage.json— it was added in chore: bump nextjs version to fix vulnerabilities (#704) #705 (Dec 2025) to silence audit findings from Next 14's transitive deps, and the dep graph no longer produces those findings under Next 16.package-lock.jsonto the override-free resolution.Audit findings (
npm auditshows zero glob-related vulns at v7/v11/v13)npm auditvulns^13.0.1)^7.1.3)Removing the override:
@joshwooding/vite-plugin-react-docgen-typescriptwith its declaredglob ^13.0.1(the override was silently downgrading it).^7.1.3— what Jest 29 was designed against.npm warn deprecated inflight@1.0.6warning during install (Jest 29 → glob@7 → inflight). Cosmetic; not a CI failure.Verification
npx tsc --noEmit— cleannpm test— 447 tests passfran/x-nextjs-testwith local tarball:npm run build:anvil-cmgsucceeded end-to-end (all pages prerendered, next-sitemap generated).Closes #940.
Test plan
npm auditdoesn't surface new glob-related findings after this lands🤖 Generated with Claude Code