ID-1174 Combine loadTerraUser sam api calls into one #4844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghost-in-a-Jar
force-pushed
the
ID-1174-combine-user-state-api-calls
branch
from
47f4a0c to
446e3d8
Compare
Ghost-in-a-Jar
force-pushed
the
ID-1174-combine-user-state-api-calls
branch
from
5d6b49e to
fe5381b
Compare
Ghost-in-a-Jar
force-pushed
the
ID-1174-combine-user-state-api-calls
branch
from
c105f9d to
e8c08c6
Compare
Ghost-in-a-Jar
force-pushed
the
ID-1174-combine-user-state-api-calls
branch
from
e8c08c6 to
37aee3d
Compare
Ghost-in-a-Jar
force-pushed
the
ID-1174-combine-user-state-api-calls
branch
from
37aee3d to
46bec17
Compare
Ghost-in-a-Jar
force-pushed
the
ID-1174-combine-user-state-api-calls
branch
from
d2ca63e to
2280d55
Compare
nawatts
reviewed
May 23, 2024
Co-authored-by: Nick Watts <[email protected]>
Co-authored-by: Nick Watts <[email protected]>
Co-authored-by: Nick Watts <[email protected]>
Co-authored-by: Nick Watts <[email protected]>
samanehsan
approved these changes
May 23, 2024
nawatts
approved these changes
May 23, 2024
Ghost-in-a-Jar
force-pushed
the
ID-1174-combine-user-state-api-calls
branch
from
ecdf2e2 to
3c2833a
Compare
|
My local merge did something weird and i ended up pushing up a bunch of changes to random files, then the pr requested review of a bunch of people and I cant undo it. I will probably remake the pr today. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/ID-1174
New endpoint in sam: broadinstitute/sam#1414
Summary of changes:
This pr is to combine the 5 api calls the ui does to sam as it loads a terra user into 1. This should improve the speed of registration, terms of service, and login. It is also a followup from a prod incident.
What
Replace 5 sam api calls in loadTerraUser with a single one that hits a new endpoint.
Why
In general, Terra-UI is very chatty with Terra APIs. This leads to an increased risk of call failure. This change should make the ui less error prone and simplify things.
Testing strategy
I will test out the registration, tos acceptance, and login in a bee.