[TSPS-156] Imputation UI feature branch [WIP] #5325
Draft
+2,709
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Weitz <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the Imputation UI feature branch with new pages, components, and supporting changes for running jobs, viewing job histories, and displaying imputation service details.
- Added new views: RunJob, JobHistory, and Home for the Imputation service.
- Updated routing, branding, and AJAX modules to support the new feature.
- Provided a new sidebar widget for quota and helpful tips, and extended test coverage for the job history table.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/scientificServices/imputation/views/RunJob.tsx | New view to run imputation jobs; includes minor parsing improvement. |
| src/pages/scientificServices/imputation/views/JobHistory.tsx | New page that displays a table of pipeline runs with actions and status. |
| src/pages/scientificServices/imputation/views/JobHistory.test.tsx | Added tests for verifying the job history table rendering. |
| src/pages/scientificServices/imputation/views/Home.tsx | Home page for the imputation service with service details and links. |
| src/pages/scientificServices/imputation/common/scientific-services-common.tsx | Provides the top bar and navigation for the imputation feature. |
| src/pages/scientificServices/imputation/common/SidebarWidgets.tsx | New sidebar widget displaying quota information and useful tips. |
| src/pages/scientificServices/ScientificServicesLandingPage.tsx | Landing page component for the Broad Data Science Services. |
| src/pages/scientificServices/NavPaths.tsx | Defines new navigation paths for the imputation service views. |
| src/pages/LandingPage.js | Updated with a TODO comment regarding menu adjustments. |
| src/libs/routes.js | Updated routes to include the new imputation service paths. |
| src/libs/brands.tsx | Added brand configuration for scientific services. |
| src/libs/brand-utils.ts | Added a helper for checking the scientific services brand. |
| src/libs/ajax/teaspoons/* (models, Teaspoons.ts, ajax-common.ts) | New API client methods and types to support imputation pipelines. |
| src/components/HeroWrapper.js | Minor adjustment to conditionally display the welcome header. |
| config/dev.json | Updated configuration with the new Teaspoons URL. |
Co-authored-by: Eric Weitz <[email protected]>
…more components (#5335)
Co-authored-by: Matt Bemis <[email protected]>
|
MatthewBemis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/TSPS-156
This is a WIP feature branch for the Imputation UI.
Summary of changes:
What
Why
Testing strategy