[TSPS-519] Add version number to pipeline run history page #5341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewBemis
commented
Jun 10, 2025
| @@ -32,6 +32,7 @@ export interface UserPipelineQuotaDetails { | |||
| export interface PipelineRun { | |||
| jobId: string; | |||
| pipelineName: string; | |||
| pipelineVersion?: number; | |||
There was a problem hiding this comment.
depending on merge order w/ the backend code, this will eventually be required. i'll clean it up accordingly, but for the sake of iteration speed and backwards compatibility, it can merge like this (IMO)
jsotobroad
approved these changes
Jun 10, 2025
4 tasks
eweitz
approved these changes
Jun 12, 2025
|
|
merging this - the related failures are due to gcp outage and this is going into a feature branch anyway |
MatthewBemis
merged commit 155f751
into
tsps_imputation_ui_feature_branch
5 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/519
There are some small backend changes required to return the pipeline version number, which I'll PR shortly. In the meantime, this UI change is resilient to the missing field so we can merge the PRs in any order without breakage.
Summary of changes:
What
Why
Testing strategy