simplify

thomas-lebeau · thomas-lebeau · commit cde4571cd3a8 · 2025-05-15T09:35:56.000+02:00
diff --git a/packages/rum-core/src/domain/view/viewCollection.spec.ts b/packages/rum-core/src/domain/view/viewCollection.spec.ts
@@ -115,10 +115,7 @@ describe('viewCollection', () => {
       _dd: {
         document_version: 3,
         replay_stats: undefined,
-        loading_time: {
-          was_hidden_during_loading: undefined,
-          duration: 20,
-        },
+        was_hidden_during_loading: undefined,
         configuration: {
           start_session_replay_recording_manually: jasmine.any(Boolean),
         },
diff --git a/packages/rum-core/src/domain/view/viewCollection.ts b/packages/rum-core/src/domain/view/viewCollection.ts
@@ -79,10 +79,7 @@ function processViewUpdate(
             device_pixel_ratio: clsDevicePixelRatio,
           }
         : undefined,
-      loading_time: {
-        was_hidden_during_loading: view.commonViewMetrics.wasHiddenDuringLoading,
-        duration: view.commonViewMetrics.loadingTime,
-      },
+      was_hidden_during_loading: view.commonViewMetrics.wasHiddenDuringLoading,
       configuration: {
         start_session_replay_recording_manually: configuration.startSessionReplayRecordingManually,
       },
diff --git a/packages/rum-core/src/domain/view/viewMetrics/trackCommonViewMetrics.ts b/packages/rum-core/src/domain/view/viewMetrics/trackCommonViewMetrics.ts
@@ -37,11 +37,8 @@ export function trackCommonViewMetrics(
     loadingType,
     viewStart,
     (newLoadingTime, wasHiddenDuringLoading) => {
-      if (wasHiddenDuringLoading) {
-        commonViewMetrics.wasHiddenDuringLoading = true
-      } else {
-        commonViewMetrics.loadingTime = newLoadingTime
-      }
+      commonViewMetrics.wasHiddenDuringLoading = wasHiddenDuringLoading
+      commonViewMetrics.loadingTime = newLoadingTime
       scheduleViewUpdate()
     }
   )

Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,8 @@ export function trackCommonViewMetrics(`
`37`	`37`	`loadingType,`
`38`	`38`	`viewStart,`
`39`	`39`	`(newLoadingTime, wasHiddenDuringLoading) => {`
`40`		`- if (wasHiddenDuringLoading) {`
`41`		`- commonViewMetrics.wasHiddenDuringLoading = true`
`42`		`- } else {`
`43`		`- commonViewMetrics.loadingTime = newLoadingTime`
`44`		`- }`
	`40`	`+ commonViewMetrics.wasHiddenDuringLoading = wasHiddenDuringLoading`
	`41`	`+ commonViewMetrics.loadingTime = newLoadingTime`
`45`	`42`	`scheduleViewUpdate()`
`46`	`43`	`}`
`47`	`44`	`)`