-
Notifications
You must be signed in to change notification settings - Fork 154
👷 add _dd.was_hidden_during_loading to view events #3529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3529 +/- ##
==========================================
- Coverage 92.09% 92.08% -0.01%
==========================================
Files 315 315
Lines 8055 8061 +6
Branches 1818 1821 +3
==========================================
+ Hits 7418 7423 +5
- Misses 637 638 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clock.tick(BEFORE_PAGE_ACTIVITY_VALIDATION_DELAY) | ||
domMutationObservable.notify() | ||
clock.tick(AFTER_PAGE_ACTIVITY_END_DELAY) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no activity, loadingTimeCallback
is not expected to be called anyway (this is the same test as line 56 and setting the visibility or not has no effect!
acd25f4
to
16e35ec
Compare
/to-staging |
View all feedbacks in Devflow UI.
Commit 16e35ec259 will soon be integrated into staging-20.
We couldn't automatically merge the commit 16e35ec259 into staging-20. What to do next?
If you think the errors come from a logical conflict with the target branch, you can create a fix by commenting this pull request with DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
/create-fix-branch -b staging-20 |
View all feedbacks in Devflow UI.
Created fix branch fix-merge-16e35ec259-into-staging-20 - #3534 |
🚂 Branch Integration: starting soon, merge expected in approximately 20m53s (p90) Commit 16e35ec259 will soon be integrated into staging-20. |
🚂 Branch Integration Commit 16e35ec259 has been merged into staging-20 in merge commit c660aadaf8. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
4a6e176
to
16e35ec
Compare
16e35ec
to
36a6ae8
Compare
Motivation
Changes
Test instructions
Checklist