Skip to content

👷 add _dd.was_hidden_during_loading to view events #3529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

thomas-lebeau
Copy link
Collaborator

Motivation

Changes

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@thomas-lebeau thomas-lebeau changed the title Thomas.lebeau/loading time 👷 add _dd.was_hidden_during_loading to view events May 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.08%. Comparing base (ee3b54c) to head (49f9aa4).

Files with missing lines Patch % Lines
packages/rum-core/src/domain/assembly.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3529      +/-   ##
==========================================
- Coverage   92.09%   92.08%   -0.01%     
==========================================
  Files         315      315              
  Lines        8055     8061       +6     
  Branches     1818     1821       +3     
==========================================
+ Hits         7418     7423       +5     
- Misses        637      638       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +139 to +140
clock.tick(BEFORE_PAGE_ACTIVITY_VALIDATION_DELAY)
domMutationObservable.notify()
clock.tick(AFTER_PAGE_ACTIVITY_END_DELAY)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no activity, loadingTimeCallback is not expected to be called anyway (this is the same test as line 56 and setting the visibility or not has no effect!

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/loading_time branch from acd25f4 to 16e35ec Compare May 15, 2025 07:59
@thomas-lebeau
Copy link
Collaborator Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented May 15, 2025

View all feedbacks in Devflow UI.

2025-05-15 08:57:43 UTC ℹ️ Start processing command /to-staging


2025-05-15 08:57:50 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 20m53s (p90)

Commit 16e35ec259 will soon be integrated into staging-20.


2025-05-15 09:01:28 UTC 🚨 Branch Integration: The build pipeline contains failing jobs for this merge request

We couldn't automatically merge the commit 16e35ec259 into staging-20.
Build pipeline has failing jobs for 4d429f1:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

If you think the errors come from a logical conflict with the target branch, you can create a fix by commenting this pull request with /create-fix-branch -b staging-20

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@thomas-lebeau
Copy link
Collaborator Author

/create-fix-branch -b staging-20

@dd-devflow
Copy link
Contributor

dd-devflow bot commented May 15, 2025

View all feedbacks in Devflow UI.

2025-05-15 09:17:42 UTC ℹ️ Start processing command /create-fix-branch -b staging-20


2025-05-15 09:17:49 UTC ℹ️ Devflow: /create-fix-branch -b staging-20

Created fix branch fix-merge-16e35ec259-into-staging-20 - #3534

dd-devflow bot added a commit that referenced this pull request May 15, 2025
@dd-devflow
Copy link
Contributor

dd-devflow bot commented May 15, 2025

🚂 Branch Integration: starting soon, merge expected in approximately 20m53s (p90)

Commit 16e35ec259 will soon be integrated into staging-20.

@dd-devflow
Copy link
Contributor

dd-devflow bot commented May 15, 2025

🚂 Branch Integration

Commit 16e35ec259 has been merged into staging-20 in merge commit c660aadaf8.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-20

Copy link

cit-pr-commenter bot commented May 16, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 145.27 KiB 145.52 KiB 252 B +0.17%
Rum Recorder 18.03 KiB 18.03 KiB 0 B 0.00%
Rum Profiler 4.73 KiB 4.73 KiB 0 B 0.00%
Logs 49.92 KiB 49.92 KiB 0 B 0.00%
Rum Slim 104.90 KiB 105.15 KiB 252 B +0.23%
Worker 23.59 KiB 23.59 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.003 0.002 -0.001
addaction 0.073 0.039 -0.033
addtiming 0.002 0.001 -0.001
adderror 0.088 0.050 -0.038
startstopsessionreplayrecording 0.014 0.013 -0.001
startview 0.460 0.386 -0.074
logmessage 0.024 0.020 -0.003
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 25.76 KiB 25.85 KiB 98 B
addaction 55.89 KiB 55.22 KiB -689 B
addtiming 24.62 KiB 23.94 KiB -699 B
adderror 60.64 KiB 55.52 KiB -5235 B
startstopsessionreplayrecording 22.83 KiB 24.14 KiB 1.32 KiB
startview 426.48 KiB 429.00 KiB 2.51 KiB
logmessage 57.63 KiB 58.27 KiB 656 B

🔗 RealWorld

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/loading_time branch from 4a6e176 to 16e35ec Compare May 16, 2025 13:02
@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/loading_time branch from 16e35ec to 36a6ae8 Compare May 16, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants