👷 do not rely on hardcoded list of DCs

[thomas-lebeau]

Motivation

We want to avoid hardcoding the list of datacenter in the release process. This will remove the need for creating a PR for new DCs.

For this we discover the list of DC and their corresponding site using ddtool Runtime Metadata Service.

PR stacked on top of #3973

Changes

• Refactor a bit to normalize usage of datacenter vs uploadPath and try to make things more clear
• Added unit tests for deploy-prod-dc script.
• removed siteByDatacenter in favor of a ddtool command a call to Runtime Metadata Service

Todos

• install ddtool on the CI (or find another way) used Runtime Metadata Service
• fix upload-source-maps test failing. for some reason the mock seems to initialize too late

Test instructions

Checklist

• Tested locally
• Tested on staging
• Added unit tests for this change.
• Added e2e/integration tests for this change.

[datadog-official]

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
• Patch Coverage: 100.00%
• Overall Coverage: 77.28% (+0.00%)

View detailed report

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2f8cb69 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

[cit-pr-commenter]

Bundles Sizes Evolution

📦 Bundle Name	Base Size	Local Size	𝚫	𝚫%	Status
Rum	164.29 KiB	164.29 KiB	0 B	0.00%	✅
Rum Profiler	4.33 KiB	4.33 KiB	0 B	0.00%	✅
Rum Recorder	20.01 KiB	20.01 KiB	0 B	0.00%	✅
Logs	56.10 KiB	56.10 KiB	0 B	0.00%	✅
Flagging	944 B	944 B	0 B	0.00%	✅
Rum Slim	121.50 KiB	121.50 KiB	0 B	0.00%	✅
Worker	23.63 KiB	23.63 KiB	0 B	0.00%	✅

🚀 CPU Performance

Pending...

🧠 Memory Performance

Pending...

🔗 RealWorld

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38ec673ee6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[BenoitZugmeyer]

nitpick: calling getAllDatacentersMetadata multiple times synchronously won't leverage the cache.

Suggested change

	let cachedDatacenters: Record<string, Datacenter> | undefined
	async function getAllDatacentersMetadata(): Promise<Record<string, Datacenter>> {
	if (cachedDatacenters) {
	return cachedDatacenters
	}
	let cachedDatacenters: Promise<Record<string, Datacenter>> | undefined
	async function getAllDatacentersMetadata(): Promise<Record<string, Datacenter>> {
	if (cachedDatacenters) {
	return cachedDatacenters
	}
	cachedDatacenters = fetchDatacentersFromRuntimeMetadataService().then(...)

[BenoitZugmeyer]

nitpick: it could be nice to have a createMockResponse function with defaults, like this:

function createMockResopnse({ status = 200, json }: { status?: number, json?: any }) {
    return {
        ok: status < 300,
        status,
        json: () => Promise.resolve(json),
        text: () => Promise.resolve(JSON.stringify(json))
    }
}

[BenoitZugmeyer]

suggestion: maybe introduce something like:

enum DatacenterType {
  // ... what is a minor dc ...
  Minor,
  // ... what is a major dc ..
  Major,
  // ... what is a private region ...
  PrivateRegion
}

return getDatacenterType(name: string) {
  // ...
}

[BenoitZugmeyer]

suggestion: why not exposing this type more, so we don't need call getSite as much and things would be a bit less async

name could be the shortName, as we never use the full name anywhere?

Also (referring to my previous comment) we could add the type:

Suggested change

	interface Datacenter {
	name: string
	site: string
	}
	interface Datacenter {
	name: string
	site: string
	type: DatacenterType
	}