✨ Add angular router integration#4498
Draft
amortemousque wants to merge 12 commits intomainfrom
Draft
Conversation
Design for a fully automated Claude Code skill pipeline that generates draft Browser SDK router integration PRs from framework public docs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Updated spec: skills use separate subdirectories (SKILL.md per dir) - Plan covers 7 tasks: orchestrator + 5 stage skills + validation - Each task has step-by-step instructions with exact file paths Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Six Claude Code skills forming an automated pipeline: - router:pipeline — orchestrator chaining all stages - router:fetch-docs — Stage 1: fetch & extract router concepts - router:analyze — Stage 2: map to SDK patterns - router:design — Stage 3: produce design decisions - router:generate — Stage 4: generate package code - router:pr — Stage 5: create draft PR Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Generated by the router integration pipeline. Artifacts: router concepts, design decisions, generation manifest.
Auto-generated from framework documentation using the router integration pipeline. See docs/integrations/angular/ for design artifacts and decision rationale.
Bundles Sizes Evolution
🚀 CPU PerformancePending... 🧠 Memory Performance
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: c5882a1 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auto-generated router integration for angular using the router integration pipeline.
startView()on route changesDesign Artifacts
Full design trail at
docs/integrations/angular/:01-router-concepts.json— structured routing concepts extracted from framework docs02-design-decisions.json— hook selection, wrapping strategy, algorithm family decisions03-generation-manifest.md— list of generated files with lineageKey Decisions
ResolveStart— unique survivor of the priority filter (afterCancellation:true, afterRedirects:true, afterFetch:false, afterRender:false). Guards have passed and redirects are applied, but resolvers/activation/render happen after — so resource fetches and long tasks are attributed to the new view.provideDatadogRouter()returns aProvider[]registering anENVIRONMENT_INITIALIZERthat usesinject(Router)to subscribe torouter.events. This is Angular's canonical DI integration pattern (mirrorsprovideHttpClient,provideAnimations) since Angular has no factory-wrapping convention analogous tovue-router'screateRouter.state.root'sfirstChildchain, concatenating non-emptyrouteConfig.pathsegments with/. Handles the**catch-all by substituting the remaining segments ofevent.urlAfterRedirects. Same family as rum-vue and rum-react; strictly preferred over route-id (Angular has no parameterized-pattern string) and param-substitution (lossy).Test plan
docs/integrations/angular/yarn typecheckto verify type correctnessyarn test:unit --spec packages/rum-angular/to verify tests passcomputeViewName()edge cases🤖 Generated with the router integration pipeline