Tighten Live Debugger global hook typing#4508
Draft
watson wants to merge 1 commit intowatson/DEBUG-5296/add-live-debuggerfrom
Draft
Tighten Live Debugger global hook typing#4508watson wants to merge 1 commit intowatson/DEBUG-5296/add-live-debuggerfrom
watson wants to merge 1 commit intowatson/DEBUG-5296/add-live-debuggerfrom
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 21, 2026
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: c5ebc6b | Docs | Datadog PR Page | Give us feedback! |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
This was referenced Apr 21, 2026
8027d31 to
bc24fd5
Compare
bf9a162 to
b9da4f3
Compare
bc24fd5 to
6f0a5f4
Compare
b9da4f3 to
0040ee8
Compare
5 tasks
6f0a5f4 to
eaee933
Compare
0040ee8 to
653aee9
Compare
eaee933 to
05a34bf
Compare
653aee9 to
7d1efe7
Compare
Replace `any` casts when installing debugger globals with an explicit typed global interface so the runtime stays lint-clean without changing behavior.
05a34bf to
c5ebc6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Avoid unsafe
anycasts in the Live Debugger global hook setup.Changes
Replace
anycasts used when assigning$dd_entry,$dd_return,$dd_throw, and$dd_probesonglobalThiswith a small explicitDebuggerInstrumentationGlobaltype inpackages/debugger/src/entries/main.ts.Test instructions
packages/debugger/src/entries/main.ts.init().Checklist