👷 run latest firefox and webkit in CI, default local e2e to chromium - #4618
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 544f22ee07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenoitZugmeyer
approved these changes
May 13, 2026
thomas-lebeau
force-pushed
the
thomas.lebeau/e2e-latest-browsers-in-ci
branch
from
May 13, 2026 13:48
544f22e to
4ea9e76
Compare
Bundles Sizes Evolution
|
BenoitZugmeyer
approved these changes
May 13, 2026
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c7a2412 | Docs | Datadog PR Page | Give us feedback! |
mormubis
approved these changes
May 14, 2026
5 tasks
thomas-lebeau
force-pushed
the
thomas.lebeau/e2e-latest-browsers-in-ci
branch
2 times, most recently
from
May 15, 2026 19:21
573ba97 to
0c3132a
Compare
Adds firefox and webkit to the CI e2e matrix alongside chromium so we catch cross-browser regressions on the latest browser versions (in addition to the existing pinned variants). Installs the matching Playwright browsers in the CI image and bumps CURRENT_CI_IMAGE to 108. Defaults local `yarn test:e2e` to chromium only to keep the local feedback loop fast; other browsers can still be run via `--project=`.
thomas-lebeau
force-pushed
the
thomas.lebeau/e2e-latest-browsers-in-ci
branch
from
May 26, 2026 10:35
2671799 to
a32f1d3
Compare
- reset lifecycle tracker in cleanup to avoid cross-test state leakage - await a microtask before updating consent so startSessionManager can finish awaiting selectSessionStoreStrategyType and call setSessionState
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We only ran the latest Chromium in CI e2e, alongside pinned variants of Chromium 120, Firefox 119 and WebKit 17.4 (added in #4612). This left a gap: regressions on the latest Firefox/WebKit versions weren't caught until they shipped. Locally, running all browsers also made the e2e feedback loop slow.
Changes
.gitlab-ci.yml: addfirefoxandwebkitto the e2e job'sBROWSERmatrix (in addition to the existingchromium/*-pinnedprojects). BumpCURRENT_CI_IMAGEto108.Dockerfile: install Playwright'sfirefoxandwebkitbrowsers (with deps) in the CI image so the new matrix entries have what they need.Test instructions
firefoxandwebkitmatrix entries successfully on the freshly built image108.yarn test:e2eshould now run chromium only.yarn test:e2e --project=firefoxstill works for opting in to other browsers.Checklist