Skip to content

👷 Allow version bump titles in PR #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdibon merged 1 commit into from
May 27, 2026
+10 −0
Merged

👷 Allow version bump titles in PR #4681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/check-pr-title.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ describe('isValidPrTitle', () => {
assert.equal(isValidPrTitle('⚡ Speed up'), true)
})

it('accepts version bump titles like v7.2.0', () => {
assert.equal(isValidPrTitle('v7.2.0'), true)
assert.equal(isValidPrTitle('v1.0.0'), true)
assert.equal(isValidPrTitle('v10.12.34'), true)
})

it('rejects titles without any allowed emoji prefix', () => {
assert.equal(isValidPrTitle('Add new feature'), false)
assert.equal(isValidPrTitle('feat: add thing'), false)
Expand Down
4 changes: 4 additions & 0 deletions scripts/check-pr-title.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ import { printError, printLog, runMain } from './lib/executionUtils.ts'
import { GITMOJI, normalizeGitmoji } from './lib/gitmoji.ts'

export function isValidPrTitle(title: string): boolean {
if (/^v\d+\.\d+\.\d+$/.test(title)) {
return true
}

const normalized = normalizeGitmoji(title)
return GITMOJI.some(({ emoji }) => normalized.startsWith(normalizeGitmoji(emoji)))
}
Expand Down
Loading