Skip to content

[chore] Drop webpack 4 support - #189

Merged
yoannmoinet merged 4 commits into
v3from
yoann/drop-webpack-4
Jul 23, 2025
Merged

[chore] Drop webpack 4 support#189
yoannmoinet merged 4 commits into
v3from
yoann/drop-webpack-4

Conversation

@yoannmoinet

@yoannmoinet yoannmoinet commented Jul 22, 2025

Copy link
Copy Markdown
Member

This will be merged into the v3 branch, and held until all the breaking changes have been made.

Remove Webpack 4 Support

This PR removes support for Webpack 4, simplifying our codebase and reducing maintenance burden.

Changes

Core Infrastructure

  • Removed BundlerFullName type and FULL_NAME_BUNDLERS constant
  • Removed fullName and variant fields from bundler types
  • Unified webpack handling to use single 'webpack' identifier
  • Removed all webpack 4 related dependencies

Build System Updates

  • Consolidated buildWithWebpack4/buildWithWebpack5buildWithWebpack
  • Consolidated configWebpack4/configWebpack5configWebpack
  • Removed webpack 4 specific test helpers (getWebpackPlugin.ts)

Plugin Updates

  • Removed webpack 4 conditional logic

Test Plan

  • Unit tests pass
  • E2E tests run successfully
  • Lint and type checking pass
  • No webpack 4 references remain in codebase

Breaking Changes

This is a breaking change for users still on webpack 4. They will need to upgrade to webpack 5 before using future versions of our plugins.

@yoannmoinet
yoannmoinet marked this pull request as ready for review July 22, 2025 08:19
@yoannmoinet
yoannmoinet requested a review from a team as a code owner July 22, 2025 08:19
@yoannmoinet
yoannmoinet requested review from jakub-g and removed request for a team July 22, 2025 08:19
@yoannmoinet
yoannmoinet changed the base branch from master to v3 July 22, 2025 08:32
@yoannmoinet
yoannmoinet force-pushed the yoann/drop-webpack-4 branch from 934cb3a to f2096b1 Compare July 22, 2025 12:56
@yoannmoinet
yoannmoinet changed the base branch from v3 to yoann/node-v20 July 22, 2025 12:57
@yoannmoinet yoannmoinet changed the title Drop webpack 4 support [chore] Drop webpack 4 support Jul 22, 2025
@yoannmoinet yoannmoinet added the v3 label Jul 22, 2025
Base automatically changed from yoann/node-v20 to v3 July 23, 2025 12:48
@yoannmoinet
yoannmoinet merged commit 1859095 into v3 Jul 23, 2025
4 checks passed
@yoannmoinet
yoannmoinet deleted the yoann/drop-webpack-4 branch July 23, 2025 13:24
@yoannmoinet yoannmoinet mentioned this pull request Jul 23, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants