Assign EIP only to primary ENI - #636
Merged
Merged
Conversation
HadrienPatte
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quickfix for the issue which caused secondary ENIs to be assigned Public IPs
The main issue was that there was no check on
eni.Number == 0before assignment.Another issue was that with
first-interface-index: 1, the IPAM reconciliation loop was exiting here for the primary ENI:cilium/pkg/aws/eni/node.go
Line 639 in 123b048
so it was never saving the Public IP:
cilium/pkg/aws/eni/node.go
Lines 653 to 656 in 123b048