[Security] Pin python dependencies in Documentation/requirements-min/requirements.txt (cilium) - #659
Closed
SeanMeyer wants to merge 1 commit into
Closed
Conversation
Pin the sphinx_rtd_theme dependency from a branch reference to a specific commit hash for supply chain safety (incident-51987). Signed-off-by: Sean Meyer <sean.meyer@datadoghq.com>
SeanMeyer
force-pushed
the
pin-deps/Documentation-requirements-min-requirements-txt
branch
from
March 31, 2026 21:20
c308fa5 to
5b83eb6
Compare
SeanMeyer
marked this pull request as ready for review
April 1, 2026 01:19
Member
|
This is a public fork |
HadrienPatte
deleted the
pin-deps/Documentation-requirements-min-requirements-txt
branch
April 1, 2026 15:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins all unpinned python dependencies in
Documentation/requirements-min/requirements.txtto exact versions.Why: As part of follow-up to incident #51987 (axios supply chain compromise), the Dependency Health team is pinning all unpinned dependencies across sigma repos. Exact version pins ensure that even without a lockfile, or when lockfiles are bypassed (e.g. npx), only a deliberately-chosen version can install.
Change: The custom Sphinx theme (
sphinx-rtd-theme-cilium) was referenced via a mutable branch ref (@cilium/rebase-2023-09). It is now pinned to the exact commit hash already resolved in the compiledDocumentation/requirements.txt(77d60dbce4cc93358fa6156cbafd7c49214b3c89). All other dependencies in this file were already pinned with==X.Y.Z.Version source: Commit hash taken from the compiled
Documentation/requirements.txt(generated bymake update-requirements).Workstream: #incident-51987-future-prevention
Reviewer: Please review the pinned commit and merge when comfortable. No SDLC Security review required — codeowner review is sufficient.