pkg/azure/ipam: implementation plan for ReleaseIPs - #661
Closed
rifelpet wants to merge 2 commits into
Closed
Conversation
Documents the full scope of changes needed to implement IP release for Azure IPAM: node-level PrepareIPRelease/ReleaseIPs, new Azure API methods (VM + VMSS), operator flag wiring, and tests. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Member
|
This has since been implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReleaseIPsinpkg/azure/ipam/node.go, which currently returnsfmt.Errorf("not implemented")Background
Two compounding gaps prevent IP release from working on Azure:
PrepareIPReleasereturns an emptyReleaseAction— no IPs are selectedAllocatorAzure.StarthardcodesreleaseExcessIPs=falseinNewNodeManager— the node manager never invokes the release path regardlessBoth must be fixed together. See
pkg/azure/ipam/RELEASE_IPS_PLAN.mdfor the full plan.🤖 Generated with Claude Code