Add configurable function endpoint DNS suffix - #14
Merged
Conversation
cahillsf
changed the base branch from
main
to
stephen.cahill/fix-tls-generator
February 25, 2026 19:08
cahillsf
force-pushed
the
stephen.cahill/CLOUDR-1422-custom-function-dns
branch
from
February 26, 2026 14:31
cc9eae0 to
28f1a52
Compare
cahillsf
force-pushed
the
stephen.cahill/fix-tls-generator
branch
3 times, most recently
from
March 13, 2026 19:44
ff4ead9 to
b68fcba
Compare
cahillsf
force-pushed
the
stephen.cahill/CLOUDR-1422-custom-function-dns
branch
from
March 16, 2026 13:26
28f1a52 to
e0d7753
Compare
cahillsf
force-pushed
the
stephen.cahill/fix-tls-generator
branch
2 times, most recently
from
March 16, 2026 18:59
62304b1 to
a1314d1
Compare
cahillsf
force-pushed
the
stephen.cahill/CLOUDR-1422-custom-function-dns
branch
from
April 21, 2026 14:06
e0d7753 to
e9f498b
Compare
7 tasks
cahillsf
force-pushed
the
stephen.cahill/fix-tls-generator
branch
from
April 24, 2026 17:38
a1314d1 to
d5ca3fa
Compare
Adds a configurable DNS suffix (via CLI flag or FUNCTION_ENDPOINT_SUFFIX env var) that gets appended to function service endpoints and included in TLS SANs. This allows function gRPC endpoints to use custom DNS names instead of the default in-cluster service DNS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cahillsf
force-pushed
the
stephen.cahill/CLOUDR-1422-custom-function-dns
branch
from
April 24, 2026 17:38
e9f498b to
18ab4a7
Compare
cahillsf
marked this pull request as ready for review
May 4, 2026 21:05
Author
|
allows us to use fabric dns (configured like this) |
havenwhitney-dd
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #3
Chain of upstream PRs as of 2026-04-24
PR fix empty secret name behavior and allow reading PKI from disk #3:
v2.2-dd←stephen.cahill/fix-tls-generatorstephen.cahill/fix-tls-generator←stephen.cahill/CLOUDR-1422-custom-function-dnsSummary
--function-endpoint-suffixCLI flag (andFUNCTION_ENDPOINT_SUFFIXenv var) to thecrossplane core startcommanddns:///svc.ns.SUFFIX:portinstead ofdns:///svc.ns:portTest plan
go build ./...passesgo test ./internal/controller/pkg/runtime/...passes (including newSuccessWithEndpointSuffixtest case)FUNCTION_ENDPOINT_SUFFIXset and verify FunctionRevision endpoints and TLS SANs🤖 Generated with Claude Code