Enable Profiler Disable #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <add name="DD_INTEGRATIONS" value="%XDT_EXTENSIONPATH%\vFOLDERUNKNOWN\Tracer\integrations.json" xdt:Locator="Match(name)" xdt:Transform="Insert"/> | ||
|
|
||
| <add name="DD_TRACE_LOG_PATH" xdt:Locator="Match(name)" xdt:Transform="RemoveAll"/> |
There was a problem hiding this comment.
The log path could be another candidate where the user might want to customize
There was a problem hiding this comment.
I'd like to do this separately, because it will require changes in the install script as well.
zacharycmontoya
previously approved these changes
Nov 11, 2021
|
FWIW, the "official" (documented, at least) way of disabling the tracer is |
lucaspimentel
previously approved these changes
Nov 11, 2021
colin-higgins
force-pushed
the
colin/enable-disabling-profiler
branch
from
596e1eb to
f2a8e69
Compare
andrewlock
dismissed stale reviews from lucaspimentel and zacharycmontoya
via
f2a8e69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't overwrite
COR_ENABLE_PROFILINGorCORECLR_ENABLE_PROFILINGso users can disable the extension from app settings.Re-organize transform so it's easier to read.