Skip to content

Commit 412f580

Browse files
committed
[review-fix 4] Satisfy Network Path lint
- Remove the redundant error-path else so shared lint flavors accept the event forwarding flow. Source: lint_linux-x64 and sibling flavor lint jobs Validation: Bazel collector implementation tests passed; local DDA lint was blocked by the internal Go toolchain mirror DNS.
1 parent 8022154 commit 412f580

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

comp/networkpath/npcollector/impl/npcollector.go

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -536,14 +536,13 @@ func (s *npCollectorImpl) runTracerouteForPath(ptest *pathteststore.PathtestCont
536536
if err != nil {
537537
s.logger.Errorf("json marshall error: %s", err)
538538
return false
539-
} else {
540-
s.logger.Debugf("network path event: %s", string(payloadBytes))
541-
m := message.NewMessage(payloadBytes, nil, "", 0)
542-
err = s.epForwarder.SendEventPlatformEventBlocking(m, eventplatform.EventTypeNetworkPath)
543-
if err != nil {
544-
s.logger.Errorf("failed to send event to epForwarder: %s", err)
545-
return false
546-
}
539+
}
540+
s.logger.Debugf("network path event: %s", string(payloadBytes))
541+
m := message.NewMessage(payloadBytes, nil, "", 0)
542+
err = s.epForwarder.SendEventPlatformEventBlocking(m, eventplatform.EventTypeNetworkPath)
543+
if err != nil {
544+
s.logger.Errorf("failed to send event to epForwarder: %s", err)
545+
return false
547546
}
548547
return true
549548
}

0 commit comments

Comments
 (0)