Skip to content

Commit dc92f11

Browse files
committed
Document RC provenance at baseline selection
- Keep the compatibility invariant beside the baseline profile assignment where provenance must remain unchanged. Validation: bazel test --nocache_test_results //comp/networkpath/npcollector/impl:impl_test
1 parent 00e11c5 commit dc92f11

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

comp/networkpath/npcollector/impl/baseline.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ func addBaselineCandidate(selected []baselineCandidate, candidate baselineCandid
5959
return selected
6060
}
6161

62+
// addBaselinePath marks the path as baseline-selected without changing its
63+
// admission provenance. Paths admitted by Dynamic RC retain their config ID,
64+
// source, and tags.
6265
func addBaselinePath(selected []baselineCandidate, path common.Pathtest, signals npmodel.ConnectionSignals) []baselineCandidate {
6366
path.DynamicTestProfile = payload.DynamicTestProfileBaseline
6467
return addBaselineCandidate(selected, baselineCandidate{

comp/networkpath/npcollector/impl/npcollector.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,6 @@ func (s *npCollectorImpl) scheduleNetworkPathTests(origin payload.PathOrigin, co
323323
}
324324
for conn := range conns {
325325
connCount++
326-
// Baseline mode changes only post-filter ranking. All modes use the same
327-
// local-plus-RC filter, and any winning RC attribution is preserved below.
328326
evaluation := s.evaluateNetworkPathForConn(conn, origin, vpcSubnets)
329327
if !evaluation.shouldSchedule {
330328
s.logger.Tracef("Skipped connection: addr=%s, protocol=%s", conn.Dest, conn.Type)

0 commit comments

Comments
 (0)